fix: status errcheck issues (#28540)

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
This commit is contained in:
Rohan Sharma
2024-10-15 08:52:03 +02:00
committed by GitHub
co-authored by Ben Schumacher
parent 6bae2ea21f
commit e27867cec7
2 changed files with 10 additions and 4 deletions
-1
View File
@@ -87,7 +87,6 @@ issues:
channels/api4/scheme.go|\
channels/api4/scheme_test.go|\
channels/api4/shared_channel.go|\
channels/api4/status.go|\
channels/api4/system.go|\
channels/api4/system_local.go|\
channels/api4/team_local.go|\
+10 -3
View File
@@ -78,7 +78,9 @@ func getUserStatusesByIds(c *Context, w http.ResponseWriter, r *http.Request) {
return
}
w.Write(js)
if _, err := w.Write(js); err != nil {
c.Logger.Warn("Error while writing response", mlog.Err(err))
}
}
func updateUserStatus(c *Context, w http.ResponseWriter, r *http.Request) {
@@ -105,8 +107,13 @@ func updateUserStatus(c *Context, w http.ResponseWriter, r *http.Request) {
}
currentStatus, err := c.App.GetStatus(c.Params.UserId)
if err == nil && currentStatus.Status == model.StatusOutOfOffice && status.Status != model.StatusOutOfOffice {
c.App.DisableAutoResponder(c.AppContext, c.Params.UserId, c.IsSystemAdmin())
if err != nil {
c.Logger.Warn("Failed to get current status", mlog.Err(err))
} else if currentStatus.Status == model.StatusOutOfOffice && status.Status != model.StatusOutOfOffice {
err = c.App.DisableAutoResponder(c.AppContext, c.Params.UserId, c.IsSystemAdmin())
if err != nil {
c.Logger.Warn("Failed to disable auto-responder", mlog.Err(err))
}
}
switch status.Status {