opensource/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-09-24 16:05:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

don't do validation in constructor

Browse Source
This commit is contained in:
Julien Tant
2025-02-12 15:04:18 -07:00
parent a88c092768
commit aac155ef23
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/public/model/custom_profile_attributes.go
+1 -1
View File
@@ -99,7 +99,7 @@ func NewCustomProfileAttributesSelectOptionFromMap(m map[string]any) CustomProfi
func NewCustomProfileAttributesSelectOption(id, name, color string) CustomProfileAttributesSelectOption {
optionID := strings.TrimSpace(id)
if optionID == "" || !IsValidId(optionID) {
if optionID == "" {
optionID = NewId()
}
server/public/model/custom_profile_attributes_test.go
-10
View File
@@ -35,16 +35,6 @@ func TestNewCustomProfileAttributeSelectOption(t *testing.T) {
assert.Equal(t, "#FF0000", option.Color)
})
t.Run("generates new ID when provided ID is invalid", func(t *testing.T) {
invalidID := "invalid-id-format"
option := NewCustomProfileAttributesSelectOption(invalidID, "Test Option", "#FF0000")
assert.NotEqual(t, invalidID, option.ID)
assert.True(t, IsValidId(option.ID))
assert.Equal(t, "Test Option", option.Name)
assert.Equal(t, "#FF0000", option.Color)
})
t.Run("trims spaces from ID", func(t *testing.T) {
validID := NewId()
option := NewCustomProfileAttributesSelectOption(" "+validID+" ", "Test Option", "#FF0000")