opensource/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-08-31 01:11:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

[MM-67640] Fix checks around autotranslations permission (#35351)

Browse Source 
Automatic Merge
This commit is contained in:
Daniel Espino García
2026-03-02 10:09:28 +01:00
committed by GitHub
parent 8a4632e330
commit 5fdec79007
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
webapp/channels/src/components/channel_settings_modal/channel_settings_modal.tsx
+16 -5
View File
@@ -68,12 +68,23 @@ function ChannelSettingsModal({channelId, isOpen, onExited, focusOriginElement}:
);
const hasManageChannelBannerPermission = (channel.type === 'O' && canManagePublicChannelBanner) || (channel.type === 'P' && canManagePrivateChannelBanner);
const channelTranslationEnabled = useSelector((state: GlobalState) => getConfig(state)?.EnableAutoTranslation === 'true');
const permissionToCheck = channel.type === Constants.PRIVATE_CHANNEL ? Permissions.MANAGE_PRIVATE_CHANNEL_PROPERTIES : Permissions.MANAGE_PUBLIC_CHANNEL_PROPERTIES;
const canManageChannelTranslation = useSelector((state: GlobalState) => haveIChannelPermission(state, channel.team_id, channel.id, permissionToCheck));
const canManageChannelTranslation = useSelector((state: GlobalState) => {
const config = getConfig(state);
if (config?.EnableAutoTranslation !== 'true') {
return false;
}
const isDMorGM = channel.type === Constants.DM_CHANNEL || channel.type === Constants.GM_CHANNEL;
if (isDMorGM && config?.RestrictDMAndGMAutotranslation === 'true') {
return false;
}
const permissionToCheck = channel.type === Constants.PRIVATE_CHANNEL ? Permissions.MANAGE_PRIVATE_CHANNEL_AUTO_TRANSLATION : Permissions.MANAGE_PUBLIC_CHANNEL_AUTO_TRANSLATION;
return haveIChannelPermission(state, channel.team_id, channel.id, permissionToCheck);
});
const canManageBanner = channelBannerEnabled && hasManageChannelBannerPermission;
const shouldShowConfigurationTab = canManageBanner || (channelTranslationEnabled && canManageChannelTranslation);
const shouldShowConfigurationTab = canManageBanner || canManageChannelTranslation;
const canArchivePrivateChannels = useSelector((state: GlobalState) =>
haveIChannelPermission(state, channel.team_id, channel.id, Permissions.DELETE_PRIVATE_CHANNEL),
@@ -196,7 +207,7 @@ function ChannelSettingsModal({channelId, isOpen, onExited, focusOriginElement}:
channel={channel}
setAreThereUnsavedChanges={setAreThereUnsavedChanges}
showTabSwitchError={showTabSwitchError}
canManageChannelTranslation={channelTranslationEnabled}
canManageChannelTranslation={canManageChannelTranslation}
canManageBanner={canManageBanner}
/>
);