[PLT-8430] Auto lowercase team and channel names in API requests (#7992)

This commit is contained in:
Carlos Tadeu Panato Junior
2018-01-12 09:01:45 -05:00
committed by Joram Wilander
parent 4acc2238e9
commit 3d3a234fca
3 changed files with 10 additions and 2 deletions
+4
View File
@@ -9,6 +9,7 @@ import (
"reflect"
"sort"
"strconv"
"strings"
"testing"
"github.com/mattermost/mattermost-server/model"
@@ -1136,6 +1137,9 @@ func TestGetChannelByName(t *testing.T) {
t.Fatal("names did not match")
}
_, resp = Client.GetChannelByName(strings.ToUpper(th.BasicPrivateChannel.Name), th.BasicTeam.Id, "")
CheckNoError(t, resp)
Client.RemoveUserFromChannel(th.BasicChannel.Id, th.BasicUser.Id)
_, resp = Client.GetChannelByName(th.BasicChannel.Name, th.BasicTeam.Id, "")
CheckNoError(t, resp)
+3 -2
View File
@@ -6,6 +6,7 @@ package api4
import (
"net/http"
"strconv"
"strings"
"github.com/gorilla/mux"
)
@@ -115,11 +116,11 @@ func ApiParamsFromRequest(r *http.Request) *ApiParams {
}
if val, ok := props["team_name"]; ok {
params.TeamName = val
params.TeamName = strings.ToLower(val)
}
if val, ok := props["channel_name"]; ok {
params.ChannelName = val
params.ChannelName = strings.ToLower(val)
}
if val, ok := props["category"]; ok {
+3
View File
@@ -710,6 +710,9 @@ func TestGetTeamByName(t *testing.T) {
_, resp = Client.GetTeamByName("", "")
CheckNotFoundStatus(t, resp)
_, resp = th.SystemAdminClient.GetTeamByName(strings.ToUpper(team.Name), "")
CheckNoError(t, resp)
Client.Logout()
_, resp = Client.GetTeamByName(team.Name, "")
CheckUnauthorizedStatus(t, resp)