opensource/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-09-21 14:20:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix FIPS test failures by using model.NewTestPassword() for short passwords (#36262)

Browse Source
This commit is contained in:
Jesse Hallam
2026-04-24 14:14:40 -04:00
committed by GitHub
parent 46624d1f47
commit 1ed4d0215a
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/channels/api4/user_test.go
+6 -5
View File
@@ -3973,6 +3973,7 @@ func TestResetPassword(t *testing.T) {
return tokenErr == nil
}, 10*time.Second, 500*time.Millisecond, "Recovery token not found (%s)", recoveryTokenString)
newPwd := model.NewTestPassword()
resp, err := th.Client.ResetPassword(context.Background(), recoveryToken.Token, "")
require.Error(t, err)
CheckBadRequestStatus(t, resp)
@@ -3989,16 +3990,16 @@ func TestResetPassword(t *testing.T) {
for range model.TokenSize {
code.WriteString("a")
}
resp, err = th.Client.ResetPassword(context.Background(), code.String(), "newpasswd")
resp, err = th.Client.ResetPassword(context.Background(), code.String(), newPwd)
require.Error(t, err)
CheckBadRequestStatus(t, resp)
_, err = th.Client.ResetPassword(context.Background(), recoveryToken.Token, "newpasswd")
_, err = th.Client.ResetPassword(context.Background(), recoveryToken.Token, newPwd)
require.NoError(t, err)
_, _, err = th.Client.Login(context.Background(), user.Email, "newpasswd")
_, _, err = th.Client.Login(context.Background(), user.Email, newPwd)
require.NoError(t, err)
_, err = th.Client.Logout(context.Background())
require.NoError(t, err)
resp, err = th.Client.ResetPassword(context.Background(), recoveryToken.Token, "newpasswd")
resp, err = th.Client.ResetPassword(context.Background(), recoveryToken.Token, newPwd)
require.Error(t, err)
CheckBadRequestStatus(t, resp)
authData := model.NewId()
@@ -4028,7 +4029,7 @@ func TestResetPasswordAuditDoesNotLeakToken(t *testing.T) {
_ = th.App.Srv().Store().Token().Delete(token.Token)
}()
_, err = th.Client.ResetPassword(context.Background(), token.Token, "newPassword1!")
_, err = th.Client.ResetPassword(context.Background(), token.Token, model.NewTestPassword())
require.NoError(t, err)
audits, appErr := th.App.GetAudits(request.EmptyContext(th.TestLogger), "", 100)
server/channels/app/shared_channel_test.go
+2 -2
View File
@@ -1334,7 +1334,7 @@ func TestPluginAPIReceiveSharedChannelAttachmentSyncMsg(t *testing.T) {
remoteUser := &model.User{
Email: model.NewId() + "@remote.test",
Username: "remote-attach-" + model.NewId()[:8],
Password: "Password1!",
Password: model.NewTestPassword(),
RemoteId: model.NewPointer(rc.RemoteId),
}
remoteUser, appErr := th.App.CreateUser(th.Context, remoteUser)
@@ -1409,7 +1409,7 @@ func TestPluginAPIReceiveSharedChannelProfileImageSyncMsg(t *testing.T) {
remoteUser := &model.User{
Email: model.NewId() + "@remote.test",
Username: "remote-img-" + model.NewId()[:8],
Password: "Password1!",
Password: model.NewTestPassword(),
RemoteId: model.NewPointer(rc.RemoteId),
}
remoteUser, appErr := th.App.CreateUser(th.Context, remoteUser)