opensource/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-10-30 22:55:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix create recap channel checkbox selection (#35533)

Browse Source 
* Add agent-browser skill

* Update AGENTS.CURSOR.md

* Add guidance for localization

* Fix recap channel checkbox selection

Co-authored-by: Nick Misasi <nick13misasi@gmail.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
This commit is contained in:
Nick Misasi
2026-03-10 06:49:51 -07:00
committed by GitHub
co-authored by Nick Misasi Cursor Agent Mattermost Build
parent e5f4b982e5
commit 1e47436308
3 changed files with 65 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
webapp/channels/src/components/create_recap_modal/channel_selector.test.tsx
+35
View File
@@ -218,6 +218,23 @@ describe('ChannelSelector', () => {
expect(setSelectedChannelIds).toHaveBeenCalledWith(['channel1']);
});
it('should call setSelectedChannelIds when checkbox is clicked', async () => {
const setSelectedChannelIds = jest.fn();
renderWithContext(
<ChannelSelector
{...defaultProps}
setSelectedChannelIds={setSelectedChannelIds}
/>,
);
const checkbox = screen.getByText('Town Square').closest('.channel-selector-item')?.querySelector('input[type="checkbox"]');
expect(checkbox).not.toBeNull();
await userEvent.click(checkbox!);
expect(setSelectedChannelIds).toHaveBeenCalledWith(['channel1']);
});
it('should add channel to selection when unselected channel is clicked', async () => {
const setSelectedChannelIds = jest.fn();
renderWithContext(
@@ -249,6 +266,24 @@ describe('ChannelSelector', () => {
expect(setSelectedChannelIds).toHaveBeenCalledWith(['channel2']);
});
it('should remove channel from selection when selected checkbox is clicked', async () => {
const setSelectedChannelIds = jest.fn();
renderWithContext(
<ChannelSelector
{...defaultProps}
selectedChannelIds={['channel1', 'channel2']}
setSelectedChannelIds={setSelectedChannelIds}
/>,
);
const checkbox = screen.getByText('Town Square').closest('.channel-selector-item')?.querySelector('input[type="checkbox"]');
expect(checkbox).not.toBeNull();
await userEvent.click(checkbox!);
expect(setSelectedChannelIds).toHaveBeenCalledWith(['channel2']);
});
});
describe('Channel Icons', () => {
webapp/channels/src/components/create_recap_modal/channel_selector.tsx
+1 -1
View File
@@ -76,7 +76,7 @@ const ChannelSelector = ({selectedChannelIds, setSelectedChannelIds, myChannels,
<input
type='checkbox'
checked={isSelected}
onChange={() => {}} // Handled by parent div
onChange={() => toggleChannel(channel.id)}
onClick={(e) => e.stopPropagation()}
/>
</div>
webapp/channels/src/components/create_recap_modal/create_recap_modal.test.tsx
+29
View File
@@ -267,6 +267,35 @@ describe('CreateRecapModal', () => {
});
});
test('should enable Next on channel selection step when a checkbox is clicked', async () => {
renderWithContext(<CreateRecapModal {...defaultProps}/>, initialState);
await waitFor(() => {
const dropdownButton = screen.getByLabelText('Agent selector');
expect(dropdownButton).toHaveTextContent('Copilot');
});
const nameInput = screen.getByPlaceholderText('Give your recap a name');
await userEvent.type(nameInput, 'Test Recap');
const selectedChannelsButton = screen.getByText('Recap selected channels');
await userEvent.click(selectedChannelsButton);
const nextButton = screen.getByRole('button', {name: /next/i});
await userEvent.click(nextButton);
await waitFor(() => {
expect(screen.getByPlaceholderText('Search and select channels')).toBeInTheDocument();
});
const channelCheckbox = screen.getAllByRole('checkbox')[0];
expect(nextButton).toBeDisabled();
await userEvent.click(channelCheckbox);
await waitFor(() => expect(nextButton).not.toBeDisabled());
});
test('should maintain selected bot across step navigation', async () => {
renderWithContext(<CreateRecapModal {...defaultProps}/>, initialState);