Merge pull request #12946 from Kilo-Org/fix/agent-manager-llamacpp-schema

fix(agent-manager): support llama.cpp tool schema
This commit is contained in:
Christiaan Arnoldus
2026-08-06 15:33:32 +02:00
committed by GitHub
3 changed files with 15 additions and 4 deletions
+5
View File
@@ -0,0 +1,5 @@
---
"@kilocode/cli": patch
---
Support the Agent Manager tool with llama.cpp servers that reject prefix-only JSON Schema patterns.
@@ -117,7 +117,7 @@ const WireParams = Schema.Struct({
),
filter: Schema.optional(ListParams.fields.filter),
sessionID: Schema.optional(
SessionID.annotate({ description: "For move, use a session ID returned by action=list." }),
Schema.String.annotate({ description: "For move, use a session ID returned by action=list (IDs start with ses_)." }),
),
prompt: Schema.optional(PromptParams.fields.prompt),
sectionID: Schema.optional(MoveParams.fields.sectionID),
@@ -1,10 +1,10 @@
import { AppNodeBuilder } from "@opencode-ai/core/effect/app-node-builder"
import { describe, expect, test } from "bun:test"
import { Effect, Layer, ManagedRuntime, Queue } from "effect"
import { Effect, Layer, ManagedRuntime, Queue, Schema } from "effect"
import { MessageID, SessionID } from "../../src/session/schema"
import { provideTmpdirInstance } from "../fixture/fixture"
import { CrossSpawnSpawner } from "@opencode-ai/core/cross-spawn-spawner"
import { AgentManagerTool } from "../../src/kilocode/tool/agent-manager"
import { AgentManagerTool, Params } from "../../src/kilocode/tool/agent-manager"
import { AgentManagerEvent, type AgentManagerStart } from "../../src/kilocode/agent-manager/event"
import { AgentManager } from "../../src/kilocode/agent-manager/service"
import { Bus } from "../../src/bus"
@@ -164,8 +164,9 @@ describe("agent_manager tool", () => {
expect(action && typeof action === "object" ? action.description : undefined).toContain("Use list first")
expect(action && typeof action === "object" ? action.description : undefined).toContain("Never edit")
expect(schema.properties?.sessionID).toEqual(
expect.objectContaining({ description: expect.stringContaining("returned by action=list") }),
expect.objectContaining({ description: expect.stringContaining("IDs start with ses_") }),
)
expect(schema.properties?.sessionID).not.toHaveProperty("pattern")
expect(schema.properties?.sectionID).toEqual(
expect.objectContaining({ description: expect.stringContaining("Use null to unassign") }),
)
@@ -186,6 +187,11 @@ describe("agent_manager tool", () => {
])
})
test("keeps session ID validation local", () => {
expect(Schema.is(Params)({ action: "stop", sessionID: "ses_target" })).toBe(true)
expect(Schema.is(Params)({ action: "stop", sessionID: "invalid" })).toBe(false)
})
test("asks for agent_manager permission", async () => {
const tool = await init()
const calls: unknown[] = []