refactor(telemetry): preserve event property precedence

This commit is contained in:
Christiaan Arnoldus
2026-07-29 13:05:06 +02:00
parent 304c75e600
commit a89132962d
2 changed files with 3 additions and 13 deletions
@@ -85,14 +85,10 @@ describe("TelemetryEvent", () => {
})
describe("Telemetry", () => {
test("includes immutable host OS properties", () => {
test("includes host OS properties", () => {
const capture = spyOn(Client, "capture").mockImplementation(() => {})
Telemetry.track(TelemetryEvent.CLI_START, {
os_name: "overridden",
os_version: "overridden",
os_arch: "overridden",
})
Telemetry.track(TelemetryEvent.CLI_START)
expect(capture).toHaveBeenCalledWith(
TelemetryEvent.CLI_START,
+1 -7
View File
@@ -127,13 +127,7 @@ export namespace Telemetry {
}
export function track(event: TelemetryEvent, properties?: Record<string, unknown>) {
Client.capture(event, {
...props,
...properties,
os_name: props.os_name,
os_version: props.os_version,
os_arch: props.os_arch,
})
Client.capture(event, { ...props, ...properties })
}
// CLI Lifecycle