opensource/kilocode
3
0
Fork 0
mirror of https://github.com/Kilo-Org/kilocode.git synced 2026-09-24 16:02:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10703 from barzhomi/fix/lancedb-metadata-type-corruption

Browse Source 
fix(indexing): prevent LanceDB metadata type coercion causing full re-index on restart
This commit is contained in:
Marius
2026-05-29 12:59:25 +02:00
committed by GitHub
parent bc1176242b eeff6d9df8
commit 4d1439eb0c
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/fix-lancedb-metadata-type-coercion.md
+5
View File
@@ -0,0 +1,5 @@
---
"@kilocode/cli": patch
---
Fix LanceDB metadata corruption that caused a full re-index on every VS Code restart
packages/kilo-indexing/src/indexing/vector-store/lancedb-vector-store.ts
+9 -7
View File
@@ -136,7 +136,7 @@ export class LanceDBVectorStore implements IVectorStore {
return [
{
key: KEY.size,
value: this.vectorSize,
value: String(this.vectorSize),
},
{
key: KEY.provider,
@@ -148,11 +148,11 @@ export class LanceDBVectorStore implements IVectorStore {
},
{
key: KEY.dimension,
value: this.profile.dimension,
value: String(this.profile.dimension),
},
{
key: KEY.complete,
value: false,
value: "false",
},
]
}
@@ -572,7 +572,7 @@ export class LanceDBVectorStore implements IVectorStore {
}
const metadataTable = await db.openTable(this.metadataTableName)
const metadataResults = await metadataTable.query().where(`key = '${KEY.complete}'`).toArray()
const indexed = metadataResults.length > 0 ? metadataResults[0].value : false
const indexed = metadataResults.length > 0 ? String(metadataResults[0].value) === "true" : false
log.info("LanceDB indexing metadata evaluated", {
workspacePath: this.workspacePath,
pointCount,
@@ -590,7 +590,9 @@ export class LanceDBVectorStore implements IVectorStore {
throw new Error(`Invalid metadata key: ${key}`)
}
await metadataTable.delete(`key = '${key}'`)
await metadataTable.add([{ key, value }])
// All values must be strings to prevent LanceDB from inferring the value column
// type as number from the first row, which corrupts subsequent string/boolean values.
await metadataTable.add([{ key, value: String(value) }])
}
private async _persistEmbeddingProfile(metadataTable: Table): Promise<void> {
@@ -609,7 +611,7 @@ export class LanceDBVectorStore implements IVectorStore {
const db = await this.getDb()
const metadataTable = await db.openTable(this.metadataTableName)
await this._persistEmbeddingProfile(metadataTable)
await this._upsertMetadata(metadataTable, KEY.complete, true)
await this._upsertMetadata(metadataTable, KEY.complete, "true")
log.info("Marked indexing as complete")
} catch (error) {
log.error("Failed to mark indexing as complete", { error })
@@ -626,7 +628,7 @@ export class LanceDBVectorStore implements IVectorStore {
const db = await this.getDb()
const metadataTable = await db.openTable(this.metadataTableName)
await this._persistEmbeddingProfile(metadataTable)
await this._upsertMetadata(metadataTable, KEY.complete, false)
await this._upsertMetadata(metadataTable, KEY.complete, "false")
log.info("Marked indexing as incomplete (in progress)")
} catch (error) {
log.error("Failed to mark indexing as incomplete", { error })