mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-10-31 02:28:09 +08:00
mvdbeek
97fa86b1f2
Per review, do not expose request_checksum_calculation / response_checksum_validation as user-facing, versioned template settings. Treat botocore >= 1.36 flexible checksums as a breaking change and instead guess from the endpoint: non-AWS endpoints default request_checksum_calculation to "when_required" (the pre-1.36 behavior, so existing configs keep working), while real AWS keeps botocore's stronger default. This is applied purely in client construction, so nothing is added to the versioned example templates or their config models. Remove the settings from the boto3 object store (Boto3Connection*, XML parsing, client kwds) and the s3fs file source (config models + example), including the previously released-only-on-26.1 s3fs request_checksum_calculation knob, and simplify s3_checksum_config_kwargs to take just the endpoint. Update unit tests accordingly.