opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-21 13:50:20 +08:00
Code Issues Packages Projects Releases Wiki Activity
74,994 Commits 72 Branches 243 Tags
dd9af46effe1067168a7bbdbda7c0c2dec0be6f3
Commit Graph
17867 Commits
Author SHA1 Message Date
Dannon Baker dd9af46eff Document isSubType 2024-04-11 07:45:44 -04:00
Dannon Baker c15b6e0fd3 Allow abstract parent class lookup by classname for isSubType. 2024-04-11 07:45:44 -04:00
Dannon Baker 9291173c77 In HistoryDatasetDisplay markdown element, display images in iframe 2024-04-11 07:45:44 -04:00
mvdbeek 8d62ebade2 Fix toolform not updating for version changes in wf editor 
This only happens for non-ts tools which don't have the version in their
tool id.
 2024-04-08 17:16:55 +02:00
Laila Los 7b8866495f fix computed setter infinite loop 2024-04-05 15:21:41 +02:00
mvdbeek 0bb2925a05 Make sure step removal also resets mapOver state 
Fixes https://github.com/galaxyproject/galaxy/issues/17906
 2024-04-05 13:33:18 +02:00
Aysam Guerler f3377c44d3 Merge pull request #17904 from mvdbeek/fix_losing_markdown 
[24.0] Fix lost reports when switching workflow versions
 2024-04-05 14:00:30 +03:00
Marius van den Beek e72ae4937d Merge pull request #17907 from ahmedhamidawan/dont_save_wf_without_informing 
[24.0] Do not save workflow on Run without user confirmation
 2024-04-05 09:27:36 +02:00
Ahmed Awan ad6af8d1b2 [24.0] Do not save workflow on Run without user confirmation 
This adds a modal when the user runs a workflow with changes, that asks for user confirmation on whether to proceed without saving changes or to save changes and then proceed. Currently, we _always_ save the workflow when it is run (even if there are no changes at all).

Fixes https://github.com/galaxyproject/galaxy/issues/17903
 2024-04-04 15:33:55 -05:00
mvdbeek 8630e3b343 Fix lost reports when switching workflow versions 
We serialize workflow.reports, but we were only setting it on the
workflow instance if the markdown editor emits it.

Fixes a part of https://github.com/galaxyproject/galaxy/issues/17903
 2024-04-04 18:41:34 +02:00
Martin Cech cd7de5511d disable instead of hiding 2024-04-04 09:39:23 -07:00
Martin Cech 4f331e4a70 do not show copy button when editing 2024-04-03 10:16:53 -07:00
Marius van den Beek 5548b11b0c Merge pull request #17886 from ahmedhamidawan/fix_history_has_owner_function 
[24.0] Fix hasOwner function for histories in client
 2024-04-03 11:15:52 +02:00
John Davis 098ec92a01 Merge pull request #17856 from davelopez/24.0_fix_archived_histories_mixing_with_active 
[24.0] Fix archived histories mixing with active in histories list
 2024-04-02 14:32:49 -04:00
Ahmed Awan 09f77f4d4c [24.0] Fix hasOwner function for histories in client 
The `hasOwner` function in `api/index.ts` was checking:
```
return "user_id" in history;
```

whereas, it also needed to check:
```
return "user_id" in history && history.user_id !== null;
```

because we assume histories (summaries) initally fetched for the `historyStore` without user_id are owned by the current user, but the key is still present in the backend return.

This was causing a really troublesome bug in the `HistoryScrollList` found in the history selector modal, where we could constantly keep fetching `api/histories/count` since we didn't have the expected no. of histories loaded in the component; because `historiesProxy` (which only contains owned histories) would end up being empty.
 2024-04-02 12:19:50 -05:00
Marius van den Beek 91b93ebaec Merge pull request #17865 from martenson/config-type 
[24.0] wait for config to load with user prefs options
 2024-03-29 22:24:25 +01:00
Dannon 2bba32d27c Merge pull request #17861 from ElectronicBlueberry/embed-download-fix 
[24.0] Embed download fix
 2024-03-28 19:54:19 -05:00
Martin Cech aa00cb8aa8 config is not defined yet on load 2024-03-28 14:02:50 -07:00
Marius van den Beek 30bf8ebc50 Merge pull request #17847 from ahmedhamidawan/tool_panel_slow_computed 2024-03-28 21:13:58 +01:00
davelopez d34f7582c5 Add show_archived per code review 2024-03-28 19:52:11 +01:00
Ahmed Awan 4f0f753097 set tool search worker to null to remove references while unmounted 2024-03-28 13:40:59 -05:00
Laila Los 3439265366 replace to with href 2024-03-28 17:21:31 +01:00
davelopez b301e0153c Remove style from Base component for visual consistency 2024-03-28 14:46:17 +01:00
davelopez 801eb24345 Avoid page reload for data libraries and admin pages 2024-03-28 14:24:00 +01:00
davelopez 3968449387 Move Admin, Libraries and Storage Dashboard panels 
To the center panel instead of their own full page. This will keep the activity bar always visible.
 2024-03-28 14:23:31 +01:00
Marius van den Beek f4115bbda9 Merge pull request #17852 from ElectronicBlueberry/embed-fix 
[24.0] Embed fix
 2024-03-28 10:29:42 +01:00
Marius van den Beek 75a809e0e4 Merge pull request #17812 from davelopez/24.0_fix_multi_history_counts 
[24.0] Fix Multi-History status bar reactivity
 2024-03-28 10:29:28 +01:00
Ahmed Awan 0d752671c2 keep tool search worker in toolStore to prevent multiple bundle fetches 2024-03-27 12:39:53 -05:00
Laila Los 540be69533 fix iframe tag and style 2024-03-27 16:01:30 +01:00
Dannon Baker 572a7b58aa Walk all (just the one) knownErrors 2024-03-27 10:10:34 -04:00
Dannon Baker 248bf222eb Fix miscinfo 'how to fix this' always showing 2024-03-27 09:57:44 -04:00
Dannon Baker 9b91fa580e Address reactivity bug; ensure newly added properties are reactive -- this is much cleaner in vue3... 2024-03-27 08:59:06 -04:00
davelopez c6be9412a8 Adapt client API schemas for histories 
To accurately reflect what the server is serializing for each different view or usual request from the client.
 2024-03-27 13:45:27 +01:00
davelopez d3e9c3b218 Revert schema changes in backend 
Let's do this on dev, after we evaluate what to improve.
 2024-03-27 13:27:23 +01:00
mvdbeek f719222ab3 Make toolsById a shallowRef 
A given tool never changes attributes (currently), so no need to track
reactivity for the whole object.
 2024-03-27 10:21:26 +01:00
davelopez 6b466505d6 Disable history operations conditional if multi-view 
I don't like this at all, but we don't have a way to deal with those operations in a multi-view scenario. This should be a temporary fix util we work on enabling real multi-history support both in backend and client.
 2024-03-27 10:16:03 +01:00
davelopez 7f95bf8247 Add updateContentStats action to histories store 
This allows to request only those fields that might have changed after an operation in the history contents.
 2024-03-27 10:16:02 +01:00
davelopez 7b7ee0a740 Refactor useExtendedHistory composable 2024-03-27 10:16:02 +01:00
davelopez fd02efd4e6 Drop history placeholder as it doesn't really help 2024-03-27 10:16:01 +01:00
davelopez 45e0539fa4 Refactor MultipleView.test.js to improve test setup 2024-03-27 10:16:01 +01:00
davelopez dc5a1721c3 Refactor HistoryScrollList 
To use AnyHistory type and userOwnsHistory function
 2024-03-27 10:16:00 +01:00
davelopez 23b2da38fb Fix multi-history view stats 
Add composables to deal with "extended" versions of histories when needed.
Use proper types for history references in components.
 2024-03-27 10:15:49 +01:00
davelopez 33cca2e044 Add history placeholder to prevent multiple requests 
And avoid reactivity issues with lost references
 2024-03-27 10:14:39 +01:00
davelopez 841a2812bb Use proper types for history requests in the store 
This should give us an idea of what information is
being stored and retrieved each time.
 2024-03-27 10:14:38 +01:00
davelopez 1361af872c Load current history through the historyStore in watcher 
This will make the history data available for all the app and reduce duplicated requests.
 2024-03-27 10:14:38 +01:00
davelopez 7387286540 Add HistoryDevDetailed schema model 
Technically this model is used by the "client API" in the old controllers so the current API is not using it, but it is useful to have the schema in the client to know what we are getting when requesting something from the server.
 2024-03-27 10:14:37 +01:00
davelopez 4a466f9aa0 Reduce redundant detailed history load 
The current history details will be loaded by the history watcher anyway.
 2024-03-27 10:14:37 +01:00
davelopez a132651252 Refactor async calls to avoid mixing await and then 2024-03-27 10:14:36 +01:00
mvdbeek 575806aac4 Optimize getValidToolsInEachSection 2024-03-27 09:33:11 +01:00
mvdbeek a7bff17fc4 Optimize getValidToolsInCurrentView 2024-03-27 09:33:11 +01:00