opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Drop history placeholder as it doesn't really help

Browse Source
This commit is contained in:
davelopez
2024-03-27 10:16:01 +01:00
parent 45e0539fa4
commit fd02efd4e6
1 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/stores/historyStore.ts
+1 -14
View File
@@ -68,26 +68,13 @@ export const useHistoryStore = defineStore("historyStore", () => {
const getHistoryById = computed(() => {
return (historyId: string) => {
if (!storedHistories.value[historyId]) {
// Create a placeholder to avoid multiple requests for the same history
// and reuse the reference to avoid reactivity issues
storedHistories.value[historyId] = createHistoryPlaceholder(historyId);
// TODO: Try to remove this as it can cause computed side effects
loadHistoryById(historyId);
}
return storedHistories.value[historyId]!;
return storedHistories.value[historyId] ?? null;
};
});
function createHistoryPlaceholder(historyId: string) {
const history = {
id: historyId,
name: "Loading...",
contents_active: { active: 0, deleted: 0, hidden: 0 },
} as AnyHistory;
return history;
}
const getHistoryNameById = computed(() => {
return (historyId: string) => {
const history = getHistoryById.value(historyId);