opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-21 13:50:20 +08:00
Code Issues Packages Projects Releases Wiki Activity
75,222 Commits 72 Branches 243 Tags
ab2086d5dd3067660af30af7fe98ec2199269c2a
Commit Graph
17923 Commits
Author SHA1 Message Date
mvdbeek ab2086d5dd Also filter out matchedValues using tags 
This now matched the filter in formattedOptions, so that upon first
rendering there's no discrepancy with currentValue.
 2024-05-22 15:14:12 +02:00
mvdbeek d33b0d783c Fix Select value prop type 
Can be string or array
 2024-05-22 15:14:01 +02:00
John Chilton 6b06aacd96 Merge pull request #18151 from mvdbeek/delay_tool_form_rendering_until_config_loaded 
[24.0] Delay tool form rendering until config is loaded
 2024-05-15 08:17:56 -04:00
mvdbeek 7b509b6b80 Delay tool form rendering until config is loaded 
The config typically is already loaded once you hit the tool form,
so this shouldn't cause a delay, and we already do the same effectively
for the current user and current history id.

Fixes https://github.com/galaxyproject/galaxy/issues/18139
```
TypeError: e.config is null
  at $b (webpack://@galaxyproject/galaxy-client/./src/components/Tool/ToolForm.vue?5639:1:1709)
  at Vue.prototype._render (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:2540:28)
  at updateComponent (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:2980:27)
  at Watcher.prototype.get (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:4164:33)
  at Watcher.prototype.run (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:4240:30)
...
(3 additional frame(s) were not displayed)
```
 2024-05-15 10:36:21 +02:00
Marius van den Beek ab56ee1d0a Merge pull request #18145 from mvdbeek/fix_legacy_page_view 
[24.0] Fix Legacy HTML page view
 2024-05-15 08:43:15 +02:00
Marius van den BeekandDannon 91f7bec698 Use Array.from instead of Object.values 
Co-authored-by: Dannon <dannon.baker@gmail.com>
 2024-05-15 08:42:50 +02:00
David López 6a60cc5de8 Merge pull request #18143 from dannon/fix-config-access-storagemanager 
[24.0] Fix config access in StorageManager
 2024-05-14 23:42:17 +02:00
mvdbeek 3180435cd1 Fix Legacy HTML page view 
`.children` is a HTMLCollection object which doesn't have a forEach
interface. I confirmed this renders a few old style pages successfully.

Fixes https://github.com/galaxyproject/galaxy/issues/18144
 2024-05-14 21:02:35 +02:00
Dannon Baker 81abefe501 Fix accessing config prior to it potentially being populated. We don't 
need to gate this behind a loading span, it'll just show the alert
when and if it needs to on load.
 2024-05-14 14:02:06 -04:00
Ahmed Awan a20d163342 add a LoadingSpan if there is no job response 2024-05-14 12:14:39 -05:00
Ahmed Awan 48e1eda42e [24.0] Fix undefined reading 'produces_entry_points' TypeError 
Fixes https://github.com/galaxyproject/galaxy/issues/18138
 2024-05-14 12:01:13 -05:00
Laila Los 9a938002df move next tick to reset stores function 2024-05-13 15:20:03 +02:00
Laila Los 4129a9b5ad wait for store reset to propagate 2024-05-13 15:16:40 +02:00
David López 43d79fd16e Merge pull request #18109 from mvdbeek/fix_activity_bar_touch_iphone 
[24.0] Fix activity bar touch events on iOS devices
 2024-05-13 11:46:05 +02:00
David López 2c1208dad9 Merge pull request #18112 from mvdbeek/fix_axios_error_handling 
[24.0] Fix and unify axios error handling
 2024-05-13 11:45:03 +02:00
John Davis f218a396a0 Disable download link if collection not populated 2024-05-10 16:08:44 -04:00
Martin Cech 5a88e40ae0 Merge pull request #18118 from mvdbeek/ignore_admin_required_registered_user_required_events 
[24.0] Ignore AdminRequired and RegisteredUserRequired Sentry events
 2024-05-09 22:30:14 +02:00
mvdbeek 47972859a5 Ignore AdminRequired and RegisteredUserRequired Sentry events 2024-05-09 18:37:16 +02:00
mvdbeek bec08c38e9 Fix and unify axios error handling 
Fixes https://sentry.galaxyproject.org/organizations/galaxy/issues/151896/?project=3&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=8:

```
TypeError: undefined is not an object (evaluating 'e.response.data')
  at <anonymous>(webpack://@galaxyproject/galaxy-client/src/components/Login/RegisterForm.vue:201:43)
```
 2024-05-09 17:24:21 +02:00
John Chilton 3c79a2da8e Merge pull request #18115 from mvdbeek/fix_nested_collection_switching 
[24.0] Fix switching between nested collection elements
 2024-05-09 09:50:02 -04:00
mvdbeek 1e4f406004 Merge branch 'release_23.2' into release_24.0 2024-05-09 13:08:39 +02:00
mvdbeek ff49010ff8 Fix switching between nested collection elements 
Fixes https://github.com/galaxyproject/galaxy/issues/18114
 2024-05-09 12:45:56 +02:00
Nicola Soranzo 127e4612cc Use `Annotated` and actual default value 
as recommended in
https://fastapi.tiangolo.com/tutorial/query-params-str-validations/#alternative-old-query-as-the-default-value
 2024-05-09 11:16:45 +01:00
mvdbeek c994951a71 Fix activity bar touch events on iphone 
I'm not sure what the issue is here, the minimal fix is this:
```
diff --git a/client/src/components/Popper/usePopper.ts b/client/src/components/Popper/usePopper.ts
index ad18847d8d..183d2e49be 100644
--- a/client/src/components/Popper/usePopper.ts
+++ b/client/src/components/Popper/usePopper.ts
@@ -190,7 +190,7 @@ export function usePopperjs(
                 on(referenceRef.value!, "mouseout", doMouseout);
                 on(popperRef.value!, "mouseout", doMouseout);
                 on(referenceRef.value!, "mousedown", doMouseout);
-                on(popperRef.value!, "mousedown", doMouseout);
+                // on(popperRef.value!, "mousedown", doMouseout);
                 break;
             }

```
but I think we can probably just rely on events happening on
referenceRef.
 2024-05-09 12:12:44 +02:00
mvdbeek 25825e3e30 Allow purge query param, deprecate purge body param 
Fixes https://github.com/galaxyproject/galaxy/issues/18104
 2024-05-08 09:13:03 +02:00
Ahmed Awan 2866345e8c remove a couple tooltips that render incorrectly 2024-05-03 10:40:08 -05:00
Ahmed Awan bb24c23650 [24.0] History Multiview panel shows pinned histories on top 
Fixes https://github.com/galaxyproject/galaxy/issues/18082
 2024-05-03 10:32:31 -05:00
Dannon Baker 97efceafce Explicitly specify that outputFormat is a string -- this fixes tsc getting confused below when reassigning 2024-04-26 11:25:55 -04:00
Dannon Baker fe8ecb12bf Fix usage of citations_export_message when config is not loaded yet 2024-04-26 09:42:58 -04:00
Dannon Baker d3c763821b Fix CitationsList default prop. 2024-04-26 09:17:37 -04:00
Martin Cech 625cd8a9c6 Merge pull request #18033 from martenson/storage-details 
[24.0] clarify the object store relocate functionality
 2024-04-23 17:50:16 +02:00
Martin Cech b8c39a57df change language to relocate 2024-04-22 09:58:02 -07:00
mvdbeek 5648478e6d Adjust schema for collection elements of collections that aren't populated 2024-04-22 11:52:18 +02:00
Martin Cech 03111fad43 move the link from heading to the body and change to a button 
- add minor text adjustments
- close the modal when clicking on the currently selected storage
 2024-04-19 13:23:10 -07:00
John Davis ee64fc414d Update client valid tag regex 2024-04-18 22:40:18 -04:00
Dannon Baker b648c60dd4 Add a link to histories list in history import message for situations where you import without a history visible (e.g. published page view) 2024-04-18 12:37:45 -04:00
davelopez af2c2ed314 Set active check for notifications every 30 seconds 2024-04-17 16:19:13 +02:00
davelopez 91f34ac76c Reduce notifications polling frequency 2024-04-17 16:01:41 +02:00
Marius van den Beek 88dcb255b0 Merge pull request #17990 from ahmedhamidawan/use_select_many_in_tool_form 
[24.0] Use the new column-select component in `FormData` for multiple select
 2024-04-17 12:10:20 +02:00
David López 853a645a1a Merge pull request #18005 from dannon/fix-localization-spacing 
[24.0] Preserve surrounding whitespace when localizing complex nodes
 2024-04-17 10:27:44 +02:00
Dannon Baker 3e89eeb459 Preserve surrounding whitespace when localizing complex nodes 2024-04-16 16:24:22 -04:00
Ahmed Awan f6e19c39f2 remove double ternary op 2024-04-16 11:16:38 -05:00
Dannon Baker 93a40f2aef Update client versions 2024-04-16 10:16:49 -04:00
Ahmed Awan 26844a1eab fix jest fail caused by FormSelection.props.options == null 2024-04-16 09:07:37 -05:00
Ahmed Awan 0f8c379c48 Use the new column-select component in FormData for multiple select 
This allows for easier multiselect with added ease for range select.
Fixes https://github.com/galaxyproject/galaxy/issues/17947
 2024-04-16 09:07:37 -05:00
Martin Cech 3a35c820b5 Merge pull request #17980 from dannon/history-import-feedback 
[24.0] History import - show user feedback on completion.
 2024-04-12 23:10:17 +02:00
Dannon Baker 136ae7544c In history view, add info message for when history import is complete 2024-04-12 14:53:43 -04:00
davelopez 9cd781e12f Filter workflow outputs by type in markdown directives 2024-04-12 14:52:58 +02:00
mvdbeek 32327ae496 Merge branch 'release_23.2' into release_24.0 2024-04-12 12:06:45 +02:00
Martin Cech f6a45265cb Merge pull request #17964 from dannon/fix-report-image-display 
[24.0] Show dataset image in workflow_outputs display listing.
 2024-04-11 22:47:57 +02:00