opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix activity bar touch events on iphone

Browse Source 
I'm not sure what the issue is here, the minimal fix is this:
```
diff --git a/client/src/components/Popper/usePopper.ts b/client/src/components/Popper/usePopper.ts
index ad18847d8d..183d2e49be 100644
--- a/client/src/components/Popper/usePopper.ts
+++ b/client/src/components/Popper/usePopper.ts
@@ -190,7 +190,7 @@ export function usePopperjs(
                 on(referenceRef.value!, "mouseout", doMouseout);
                 on(popperRef.value!, "mouseout", doMouseout);
                 on(referenceRef.value!, "mousedown", doMouseout);
-                on(popperRef.value!, "mousedown", doMouseout);
+                // on(popperRef.value!, "mousedown", doMouseout);
                 break;
             }

```
but I think we can probably just rely on events happening on
referenceRef.
This commit is contained in:
mvdbeek
2024-05-09 12:12:44 +02:00
parent b9808b3e8e
commit c994951a71
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/Popper/usePopper.ts
-10
View File
@@ -186,19 +186,14 @@ export function usePopperjs(
case "hover": {
on(referenceRef.value!, "mouseover", doMouseover);
on(popperRef.value!, "mouseover", doMouseover);
on(referenceRef.value!, "mouseout", doMouseout);
on(popperRef.value!, "mouseout", doMouseout);
on(referenceRef.value!, "mousedown", doMouseout);
on(popperRef.value!, "mousedown", doMouseout);
break;
}
case "focus": {
on(referenceRef.value!, "focus", doOpen);
on(popperRef.value!, "focus", doOpen);
on(referenceRef.value!, "blur", doClose);
on(popperRef.value!, "blur", doClose);
break;
}
@@ -218,16 +213,11 @@ export function usePopperjs(
off(referenceRef.value!, "click", doToggle);
off(referenceRef.value!, "mouseover", doMouseover);
off(popperRef.value!, "mouseover", doMouseover);
off(referenceRef.value!, "mouseout", doMouseout);
off(popperRef.value!, "mouseout", doMouseout);
off(referenceRef.value!, "mousedown", doMouseout);
off(popperRef.value!, "mousedown", doMouseout);
off(referenceRef.value!, "focus", doOpen);
off(popperRef.value!, "focus", doOpen);
off(referenceRef.value!, "blur", doClose);
off(popperRef.value!, "blur", doClose);
};
const doCloseForDocument = (e: Event) => {
if (referenceRef.value?.contains(e.target as Element)) {