Commit Graph
29948 Commits
Author SHA1 Message Date
John Chilton 77b61ba82d Selenium - attempted fix for transiently failing history options test.
Comments inline about this - but the target failure I'm hoping this fixes is:

https://jenkins.galaxyproject.org/job/selenium/528/artifact/528-test-errors/test_options2017092203081506064101/stacktrace.txt
2017-09-22 08:57:18 -04:00
John Chilton 3ffdfc67e7 Selenium - catch popups fading out as transitions to retry various actions on.
Previously we only detected transitions for retrying actions based on stale element exceptions, this expands that to include popups that may be fading out for instance.

I think this is what is happening with the transiently failing test here https://jenkins.galaxyproject.org/job/selenium/528/artifact/528-test-errors/test_save_as2017092203291506065342/stacktrace.txt. The exception indicates that a click was not clickable because a modal element that was fading out - though it had been previously clickable. I think this should fix that.
2017-09-22 08:57:14 -04:00
John Chilton 9e6e340adc Selenium - handle potentially stale search box on workflow index page.
https://jenkins.galaxyproject.org/job/selenium/530/artifact/530-test-errors/test_index_search2017092205301506072611/stacktrace.txt
2017-09-22 08:56:36 -04:00
John Chilton 31e2721aab Selenium - handle potentially stale elements when fetching tags.
https://jenkins.galaxyproject.org/job/selenium/529/artifact/529-test-errors/test_tagging2017092204301506069010/stacktrace.txt
2017-09-22 08:56:33 -04:00
Dannon Baker 2c7bdbfe53 Merge pull request #4673 from jmchilton/selenium_fixes_32
Fix Selenium tests outright broken in #4669.
2017-09-21 16:40:09 -04:00
John Chilton 4ee18019e0 Fix Selenium tests outright broken in #4669.
Way to go @jmchilton.
2017-09-21 15:55:35 -04:00
Nate Coraor 41b13f6d85 Merge branch 'release_17.09' into dev 2017-09-21 15:27:30 -04:00
Nate Coraor 4dbadc26e4 Merge branch 'release_17.05' into release_17.09 2017-09-21 15:27:05 -04:00
Nate Coraor cfabe37d69 Merge branch 'release_17.01' into release_17.05 2017-09-21 15:26:24 -04:00
Nate Coraor 706a5b2cd2 Merge branch 'release_16.10' into release_17.01 2017-09-21 15:25:36 -04:00
Nate Coraor e178879c0f Merge branch 'release_16.07' into release_16.10 2017-09-21 15:25:16 -04:00
Martin Cech 00677fc0f6 Merge pull request #4653 from jmchilton/selenium_fixes_28
Improve robustness of published workflow display test case.
2017-09-21 12:55:41 -04:00
Martin Cech 35cd933945 Merge pull request #4655 from jmchilton/selenium_fixes_29
Aggressively retry buggy submit_login() function in Selenium tests.
2017-09-21 12:55:20 -04:00
Martin Cech 24557fdeaa Merge pull request #4669 from jmchilton/selenium_fixes_31
Fix transiently failing saved histories due to success message disappearing.
2017-09-21 12:52:53 -04:00
Nicola Soranzo 2ffeedfa72 Merge pull request #4663 from natefoo/fix-modules-resolver
[16.07] Fix modules resolver
2017-09-21 17:33:50 +01:00
John Chilton a45e7e196b Fix transiently failing saved histories due to success message disappearing. 2017-09-21 11:13:03 -04:00
Martin Cech 98f2c10823 Merge pull request #4660 from jmchilton/selenium_fixes_30
Selenium fixes for publishing histories button.
2017-09-21 10:30:42 -04:00
John Chilton 87d5d44023 Merge pull request #4635 from mvdbeek/reload_on_macro_changes
Reload tools if a macro changes
2017-09-21 10:19:42 -04:00
John Chilton e057d7d887 Merge pull request #4620 from guerler/reduce_viz_framework
Remove unused abstraction layers from Visualizations Registry
2017-09-21 10:13:52 -04:00
John Chilton d3d134030a Rework #4635 to preserve backward compatibility on modules shared via galaxy-lib.
Also cleanup comments and such in xml_macros to reflect this doesn't apply just to tools.
2017-09-21 10:09:19 -04:00
John Chilton b369a1dc22 Merge pull request #4645 from mvdbeek/fix_liftover_tool
Make liftover tool use data tables
2017-09-21 09:54:42 -04:00
Nate Coraor 5d7b524b57 Merge pull request #4644 from mvdbeek/upload_tool_registry_xml_failure
[17.05] BUG: Explicitly write registry.xml when creating a job for the upload tool
2017-09-21 09:30:11 -04:00
John Chilton c9aead91d7 Merge pull request #4656 from dannon/display_link_fixes
[17.09] Fix links on workflow, history items.
2017-09-21 09:17:20 -04:00
John Chilton 669f944292 Merge pull request #4664 from dannon/template_cleanup
More unused template cleanup
2017-09-21 09:06:14 -04:00
Dannon Baker 12d9026b99 Merge branch 'admin_grid_formbuilder' into dev 2017-09-21 07:39:48 -04:00
Dannon Baker 71c5398f48 Merge pull request #4658 from mvdbeek/wait_for_collectino_test
Move wait_for_dataset_collection to populators
2017-09-21 07:10:19 -04:00
Nate Coraor 69a87003f7 Fix modules resolver (addition of the resolver_msg property on the base
class references name and version attributes that were not defined in
the ModuleDependecy).
2017-09-20 20:26:21 -04:00
Dannon Baker e6fc47c495 Minor typo found while grepping around. 2017-09-20 19:30:06 -04:00
Dannon Baker b86c335c65 Remove admin/tool_shed_repository/browse_category template; unused. 2017-09-20 18:47:20 -04:00
Dannon Baker 8b24d59244 Remove galaxy/admin/toolsheds template; unused. 2017-09-20 18:46:01 -04:00
Dannon Baker fbb678bc71 Remove rss template; unused. 2017-09-20 18:02:11 -04:00
mvdbeek cf9e191e27 Move wait for dataset_collection to populators.py 2017-09-20 21:42:04 +02:00
Martin Cech a25a76ab6a Merge pull request #4661 from guerler/remove_export_base
Remove unused export base mako
2017-09-20 14:25:45 -04:00
John Chilton 095307b678 Selenium fixes for publishing histories button.
Fixes https://jenkins.galaxyproject.org/job/selenium/488/testReport/junit/selenium_tests.test_published_histories_grid/HistoryGridTestCase/test_history_grid_histories/.

It looks like a Toastr popup sometimes intercepts the click, this should solve that I believe.
2017-09-20 13:35:02 -04:00
guerler 6b25b44394 Remove unused export base mako 2017-09-20 13:31:53 -04:00
Dannon Baker 5404f7cda7 Small (temporary, mako is going away) layer to support modern routes in old display_base pages (workflow, history, etc). 2017-09-20 11:20:01 -04:00
John Chilton 01eb5f04e6 Aggressively retry buggy submit_login() function in Selenium tests.
I don't get why when we click submit the user does not actually get logged in, but based on the last round of improved error messages this seems to be the case. You might think there is some callback in the login form that doesn't get registered by the time Selenium clicks the submit button - but this doesn't seem to be the case - I don't see any jquery magic happening in login.mako.

Should fix failures like this:

https://jenkins.galaxyproject.org/job/selenium/482/testReport/junit/selenium_tests.test_saved_histories/SavedHistoriesTestCase/test_history_publish/

I'd say at this point this is the most common problem in the Selenium tests.

This also introduces a framework for taking state snapshots of the Galaxy interface during tests that will only get written out if the tests fail. We now take screenshots before and after submitting the login form but this is a general purpose debugging mechanism that could be used other places.
2017-09-20 10:28:41 -04:00
John Chilton aa68d38735 Improve robustness of published workflow display test case.
Failed twice in different ways here https://jenkins.galaxyproject.org/job/selenium/484/ - this should address both cases.
2017-09-20 08:29:25 -04:00
Nicola Soranzo 0e89935460 Merge pull request #4652 from martenson/release_17.09
[17.09] pin the last missing flake8
2017-09-20 06:38:23 +01:00
Martin Cech ee6b8b1af8 pin the last flake8
thanks @nsoranzo 🦅 👀
2017-09-19 20:15:44 -04:00
John Chilton f46a5c1797 Merge pull request #4650 from martenson/release_17.09
[17.09] pin flake8 deps for release
2017-09-19 15:38:09 -04:00
John Chilton 907228928f Merge pull request #4649 from martenson/version-18.01.dev
Update version to 18.01.dev
2017-09-19 15:37:42 -04:00
John Chilton a25b6e5b0e Merge pull request #4648 from martenson/version-17.09
[17.09]Update version to 17.09.rc1
2017-09-19 15:37:31 -04:00
Martin Cech 7fd6813dd7 pin flake8 deps for release 2017-09-19 14:43:00 -04:00
mvdbeek b7b3ffb181 Fix unit test failure 2017-09-19 20:39:35 +02:00
Martin Cech 6ea93b19e5 Merge branch 'version-17.09' into version-18.01.dev 2017-09-19 14:32:47 -04:00
Martin Cech b7694ef656 Update version to 18.01.dev 2017-09-19 14:32:46 -04:00
Martin Cech eee4a17a4c Update version to 17.09.rc1 2017-09-19 14:32:41 -04:00
Martin Cech f154058776 Merge pull request #4639 from guerler/replace_spaces_url
do not wrap lines in the upload url fetch
2017-09-19 14:20:52 -04:00
John Chilton 7d394f202d Merge pull request #4640 from martenson/datalibs-optimize-access-checks
optimize the process of identifying public libraries
2017-09-19 14:18:18 -04:00