Commit Graph
527 Commits
Author SHA1 Message Date
mvdbeek 6231f4feb0 Remove `num_unique_values` tiff metadata element
This was added in https://github.com/galaxyproject/galaxy/pull/18951 but
it's memory consumption scales with input size. On a 5.5GB TIFF file
this consumed a peak of 18GB of memory.

@kostrykin added a workaround for the memory consumption in
https://github.com/galaxyproject/galaxy/pull/19830, but this now very
slow.

Besides improving the efficient, Perhaps there is a more gentle way to approach

> Many tools assume that images are binary, or label maps, for example, and it makes no sense to run those tools on other images.

?

Could those tools just error out, and/or consume a different datatype ?
Do we need the full unique values, or is it ok to just check if it's
more than `n` unique values ?
2025-06-15 11:44:10 +02:00
John Chilton 219796f049 Implement paired_or_unpaired collections, list wizards. 2025-05-09 17:39:38 -04:00
John Chilton 9c7770d3aa More dataset collection unit testing... 2025-05-09 16:38:20 -04:00
John Chilton 0b3b408b50 Migrate doctests to unit tests. 2025-05-09 16:38:19 -04:00
Eli Chadwick 70cd4511b0 avoid caching in python 3.9 2025-05-07 10:45:12 +01:00
Eli Chadwick f9688c43a7 isort 2025-05-07 10:45:11 +01:00
Eli Chadwick 09458577b2 linting 2025-05-07 10:45:10 +01:00
Eli Chadwick 007541d1e3 add version check to xfail 2025-05-07 10:45:10 +01:00
Eli Chadwick a4fbf706b4 fix version check 2025-05-07 10:45:09 +01:00
Eli Chadwick bd4da7a339 fix problem with non-existent files failing validation 2025-05-07 10:45:08 +01:00
Eli Chadwick d1906cbf54 work around dependency issues 2025-05-07 10:45:08 +01:00
Eli Chadwick 419930627b work around dependency issues 2025-05-07 10:45:08 +01:00
Eli Chadwick 5cf1dde60c checked tests 2025-05-07 10:45:07 +01:00
Eli Chadwick ed36c907b7 add tests using roc_validator 2025-05-07 10:45:06 +01:00
John Chilton 4e4017c1be Merge pull request #20152 from jmchilton/collection_cleanup_2
Fix certain cases of collection parameter handling during workflow execution.
2025-05-05 15:45:36 -04:00
John Chilton 576ed97001 Refactor history_query.py for typing, clarity, testing.
Could use some more work to be sure but a first step toward cleaning it up.
2025-05-03 10:21:17 -04:00
mvdbeek c03d179db0 Implement dataset collection support in workflow landing requests
and tweak request models to make them compatible with workflow test format
2025-04-22 14:18:47 +02:00
mvdbeek 95dd47fb3a cast MockObjectStore to BaseObjectStore 2025-03-31 18:55:20 +02:00
Marius van den Beek 346ba3d674 Merge pull request #19854 from bernt-matthias/fix-is_over_quota
Fix Galaxy ignoring job object_store_id for quota check
2025-03-26 09:58:37 +01:00
Leonid Kostrykin b638beb39e Add tests for Image base class (without PyPng) 2025-03-25 14:36:44 +01:00
Leonid Kostrykin 98f21aea20 Add Png.set_meta 2025-03-25 14:36:44 +01:00
Leonid Kostrykin f3ded28c03 Rename im9_multipage.tif -> im9_multiseries.tif 2025-03-25 14:36:42 +01:00
Matthias Bernt d6990b0707 add more complex unit test 2025-03-25 14:31:54 +01:00
Matthias Bernt 3613811030 pass quota source map instead of whole app
makes testing also a lot easier I think
2025-03-25 14:31:54 +01:00
Nicola Soranzo b7591a0872 Improve type annotations of `ModelPersistenceContext` and derived classes 2025-03-20 12:46:35 +00:00
Nicola Soranzo 05b9467c35 Merge branch 'release_24.2' into dev 2025-03-13 00:37:29 +00:00
John Davis 104a375ea4 Add get_private_role_user_emails_dict, test
Retrieves a mapping of private role ids to associated users' emails.
Used to lookup a user's email when generating a displayed_name for
private roles.
2025-03-11 00:34:22 -04:00
John Davis c4c66078d8 Factor out get_displayable_roles, add test 2025-03-10 11:13:13 -04:00
John Davis f2f55131b2 Fix unit tests 2025-03-10 11:13:13 -04:00
John Davis dfe1536a5d Update test fixture
Specify correct role name for private roles. See comment in make_role
definition for why this must be set.
2025-03-10 11:13:13 -04:00
Marius van den Beek 2df4acb8c5 Merge pull request #19666 from jmchilton/api_typing_dataset_source_transform_actions
Generate correct types for Dataset source transformations on backend.
2025-03-04 10:29:47 +01:00
Nicola Soranzo 49fa860647 Merge pull request #19706 from nsoranzo/type_annot_model
Use model classes from ``galaxy.model`` instead of ``app.model`` object - Part 1
2025-02-26 16:15:21 +00:00
Nicola Soranzo 9477c7773e Use model classes from `galaxy.model instead of app.model` object
for proper type annotation of query results.

Also:
- Drop unused code from `lib/tool_shed/webapp/controllers/user.py`
- Drop Galaxy model code from
  `lib/tool_shed/util/admin_util.py:Admin.purge_user()`
2025-02-26 12:41:40 +00:00
Nicola Soranzo edd8bccf4f Drop support for Python 3.8 2025-02-25 19:20:46 +00:00
John Chilton 099f0e2b53 Type fix for transform actions - needs to be backported to 24.2 2025-02-24 17:06:45 -05:00
John Chilton 3b4ffd5de9 Fix recording transform action name.
The upload option is space_to_tab, but we've always recorded in the source transform json blob as spaces_to_tabs. I guess the past tense version - it sort of makes sense but anyway we don't want any of these inconsistent values in the database.
2025-02-22 14:10:00 -05:00
Nicola Soranzo 0f1bfb6839 Type annotation improvements 2025-02-21 15:46:14 +00:00
mvdbeek ea353eee60 Merge branch 'release_24.1' into release_24.2 2025-02-10 10:17:23 +01:00
mvdbeek 31a3d48ff0 Merge branch 'release_24.0' into release_24.1 2025-02-10 10:17:04 +01:00
Nicola Soranzo 318aa579ed Fix type annotations for pysam 0.23.0
Partial backport of commit faa752ed03
to fix test_galaxy_packages tests.
For lines where the `type: ignore` comment is not needed any more,
here we add `unused-ignore` instead of removing the comment, so
that the (non-package) mypy tests don't fail (since those still
use an older pysam).

When merging forward, choose removing the comment (i.e. the dev
version).
2025-02-09 04:19:32 +00:00
Nicola Soranzo faa752ed03 Fix type annotations 2025-02-09 01:54:55 +00:00
Marius van den Beek 8f9dfaab48 Merge pull request #19413 from jdavcs/dev_permaban
Prevent users from reusing a banned email after account is purged
2025-02-04 19:00:59 +01:00
mjosse c6267d690d imrpove ro-crate with eli's review 2025-01-30 16:14:21 +01:00
Marius van den Beek 951044096c Drop stray print statement 2025-01-30 16:14:21 +01:00
mjosse 6204702f1d rm useless import 2025-01-30 16:14:17 +01:00
mjosse 5a2c9c3fe8 rm label 2025-01-30 16:14:17 +01:00
mjosse 89920ee828 try to fix conflicts 2025-01-30 16:14:16 +01:00
mjosse 29b9fbe860 add some tests 2025-01-30 16:14:15 +01:00
mjosse 7eee144b31 remove useless tests 2025-01-30 16:13:47 +01:00
mjosse 861174e44e fix lint rm useless import 2025-01-30 16:13:46 +01:00