opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-21 05:45:37 +08:00
Code Issues Packages Projects Releases Wiki Activity
75,337 Commits 72 Branches 243 Tags
4c8b4bf2a7db3959dae9b30fd91164b3aa35f9e9
Commit Graph
17954 Commits
Author SHA1 Message Date
davelopez 1637e202e5 Adapt History SelectorModal test 2024-05-28 14:55:37 +02:00
davelopez fa73f2e9f4 Fix conditions for userOwnsHistory and isRegisteredUser 2024-05-28 14:54:40 +02:00
Marius van den Beek d8b827f50e Merge pull request #17818 from martenson/noexpand-private 
[24.0] do not expand datasets that are known to be inaccessible
 2024-05-25 15:53:03 +02:00
davelopez 0104764bb8 Make accessible optional in HDAObject 
It is probably enough to serialize the `accessible` property only when requesting collection contents displayed in the UI.
 2024-05-24 13:43:33 +02:00
davelopez 810b246fbf Avoid requesting details for inaccessible datasets 2024-05-24 11:09:59 +02:00
davelopez a0adf7e76b Add missing event declaration 
Fixes typescript error:
Argument of type '"edit"' is not assignable to parameter of type '"toggleHighlights"'
 2024-05-24 10:53:00 +02:00
davelopez afac2afa24 Serialize accessible field for collection elements 2024-05-24 10:50:08 +02:00
davelopez 7961b475bb Fix bool const OpenAPI TS schema conversion 2024-05-24 10:47:32 +02:00
Dannon 2ddea78aef Merge pull request #18203 from ahmedhamidawan/fix_content_item_on_error 
[24.0] Add `GenericItem` error handling
 2024-05-23 13:58:51 -04:00
Ahmed Hamid AwanandMarius van den Beek cef091bcd1 Update client/src/components/History/Content/GenericItem.vue 
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
 2024-05-23 11:00:37 -05:00
Ahmed Awan 1e94915c98 add titles to Toasts for GenericItem 2024-05-23 10:34:59 -05:00
Marius van den Beek 3a89e74019 Merge pull request #18194 from ahmedhamidawan/replace_multiselect_label_with_icon 
[24.0] Replace `Multiselect` `selectLabel` with icons in `FormSelect`
 2024-05-23 11:48:36 +02:00
Marius van den Beek 154aaa162d Merge pull request #18193 from mvdbeek/fix_tag_filter_workflow_run_form 
[24.0] Fix submitted value in workflow run form if data is constrained by tag filter
 2024-05-23 11:31:32 +02:00
Ahmed Awan 09a91e0749 [24.0] Add GenericItem error handling 
`GenericItem` was missing a `onError` function. Now, it catches backend errors and displays a `Toast` message for any failed operation.
Fixes https://github.com/galaxyproject/galaxy/issues/18176
 2024-05-22 15:06:15 -05:00
Ahmed Awan 659c2fa3e1 fix jests since each option is in a div instead of a span 2024-05-22 12:24:23 -05:00
mvdbeek ab2086d5dd Also filter out matchedValues using tags 
This now matched the filter in formattedOptions, so that upon first
rendering there's no discrepancy with currentValue.
 2024-05-22 15:14:12 +02:00
mvdbeek d33b0d783c Fix Select value prop type 
Can be string or array
 2024-05-22 15:14:01 +02:00
davelopez f3c63541c6 Allow to make private purged and archived histories 2024-05-22 12:20:49 +02:00
Ahmed Awan c4b51c6dc4 Replace Multiselect selectLabel with icons in FormSelect 
Fixes https://github.com/galaxyproject/galaxy/issues/18150
 2024-05-21 13:14:32 -05:00
David López bf02164d60 Merge pull request #18188 from davelopez/24.0_fix_edit_dataset_on_error 
[24.0] Fix Edit Dataset UI when there is an error retrieving the dataset
 2024-05-21 15:39:00 +02:00
davelopez 5bd9fed08e Add client unit test for edit dataset error 2024-05-21 13:14:40 +02:00
davelopez d6087e56cf Do not show the Edit UI when error accessing the dataset 2024-05-21 12:32:13 +02:00
mvdbeek 7444544cdb Fix undefined errors in ToolSucess component 
The data is either present in the store if a user has actually submitted
or job,  or it is not. That includes both `jobDef` and `jobResponse`.
Followup to https://github.com/galaxyproject/galaxy/pull/18141.
 2024-05-20 10:40:01 +02:00
mvdbeek f3a554743e Trigger redirct before rendering form 2024-05-20 10:27:07 +02:00
John Chilton 6b06aacd96 Merge pull request #18151 from mvdbeek/delay_tool_form_rendering_until_config_loaded 
[24.0] Delay tool form rendering until config is loaded
 2024-05-15 08:17:56 -04:00
mvdbeek 7b509b6b80 Delay tool form rendering until config is loaded 
The config typically is already loaded once you hit the tool form,
so this shouldn't cause a delay, and we already do the same effectively
for the current user and current history id.

Fixes https://github.com/galaxyproject/galaxy/issues/18139
```
TypeError: e.config is null
  at $b (webpack://@galaxyproject/galaxy-client/./src/components/Tool/ToolForm.vue?5639:1:1709)
  at Vue.prototype._render (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:2540:28)
  at updateComponent (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:2980:27)
  at Watcher.prototype.get (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:4164:33)
  at Watcher.prototype.run (webpack://@galaxyproject/galaxy-client/./node_modules/vue/dist/vue.esm.js:4240:30)
...
(3 additional frame(s) were not displayed)
```
 2024-05-15 10:36:21 +02:00
Marius van den Beek ab56ee1d0a Merge pull request #18145 from mvdbeek/fix_legacy_page_view 
[24.0] Fix Legacy HTML page view
 2024-05-15 08:43:15 +02:00
Marius van den BeekandDannon 91f7bec698 Use Array.from instead of Object.values 
Co-authored-by: Dannon <dannon.baker@gmail.com>
 2024-05-15 08:42:50 +02:00
David López 6a60cc5de8 Merge pull request #18143 from dannon/fix-config-access-storagemanager 
[24.0] Fix config access in StorageManager
 2024-05-14 23:42:17 +02:00
mvdbeek 3180435cd1 Fix Legacy HTML page view 
`.children` is a HTMLCollection object which doesn't have a forEach
interface. I confirmed this renders a few old style pages successfully.

Fixes https://github.com/galaxyproject/galaxy/issues/18144
 2024-05-14 21:02:35 +02:00
Dannon Baker 81abefe501 Fix accessing config prior to it potentially being populated. We don't 
need to gate this behind a loading span, it'll just show the alert
when and if it needs to on load.
 2024-05-14 14:02:06 -04:00
Ahmed Awan a20d163342 add a LoadingSpan if there is no job response 2024-05-14 12:14:39 -05:00
Ahmed Awan 48e1eda42e [24.0] Fix undefined reading 'produces_entry_points' TypeError 
Fixes https://github.com/galaxyproject/galaxy/issues/18138
 2024-05-14 12:01:13 -05:00
Laila Los 9a938002df move next tick to reset stores function 2024-05-13 15:20:03 +02:00
Laila Los 4129a9b5ad wait for store reset to propagate 2024-05-13 15:16:40 +02:00
David López 43d79fd16e Merge pull request #18109 from mvdbeek/fix_activity_bar_touch_iphone 
[24.0] Fix activity bar touch events on iOS devices
 2024-05-13 11:46:05 +02:00
David López 2c1208dad9 Merge pull request #18112 from mvdbeek/fix_axios_error_handling 
[24.0] Fix and unify axios error handling
 2024-05-13 11:45:03 +02:00
John Davis f218a396a0 Disable download link if collection not populated 2024-05-10 16:08:44 -04:00
Martin Cech 5a88e40ae0 Merge pull request #18118 from mvdbeek/ignore_admin_required_registered_user_required_events 
[24.0] Ignore AdminRequired and RegisteredUserRequired Sentry events
 2024-05-09 22:30:14 +02:00
mvdbeek 47972859a5 Ignore AdminRequired and RegisteredUserRequired Sentry events 2024-05-09 18:37:16 +02:00
mvdbeek bec08c38e9 Fix and unify axios error handling 
Fixes https://sentry.galaxyproject.org/organizations/galaxy/issues/151896/?project=3&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=8:

```
TypeError: undefined is not an object (evaluating 'e.response.data')
  at <anonymous>(webpack://@galaxyproject/galaxy-client/src/components/Login/RegisterForm.vue:201:43)
```
 2024-05-09 17:24:21 +02:00
John Chilton 3c79a2da8e Merge pull request #18115 from mvdbeek/fix_nested_collection_switching 
[24.0] Fix switching between nested collection elements
 2024-05-09 09:50:02 -04:00
mvdbeek 1e4f406004 Merge branch 'release_23.2' into release_24.0 2024-05-09 13:08:39 +02:00
mvdbeek ff49010ff8 Fix switching between nested collection elements 
Fixes https://github.com/galaxyproject/galaxy/issues/18114
 2024-05-09 12:45:56 +02:00
Nicola Soranzo 127e4612cc Use `Annotated` and actual default value 
as recommended in
https://fastapi.tiangolo.com/tutorial/query-params-str-validations/#alternative-old-query-as-the-default-value
 2024-05-09 11:16:45 +01:00
mvdbeek c994951a71 Fix activity bar touch events on iphone 
I'm not sure what the issue is here, the minimal fix is this:
```
diff --git a/client/src/components/Popper/usePopper.ts b/client/src/components/Popper/usePopper.ts
index ad18847d8d..183d2e49be 100644
--- a/client/src/components/Popper/usePopper.ts
+++ b/client/src/components/Popper/usePopper.ts
@@ -190,7 +190,7 @@ export function usePopperjs(
                 on(referenceRef.value!, "mouseout", doMouseout);
                 on(popperRef.value!, "mouseout", doMouseout);
                 on(referenceRef.value!, "mousedown", doMouseout);
-                on(popperRef.value!, "mousedown", doMouseout);
+                // on(popperRef.value!, "mousedown", doMouseout);
                 break;
             }

```
but I think we can probably just rely on events happening on
referenceRef.
 2024-05-09 12:12:44 +02:00
mvdbeek 25825e3e30 Allow purge query param, deprecate purge body param 
Fixes https://github.com/galaxyproject/galaxy/issues/18104
 2024-05-08 09:13:03 +02:00
Ahmed Awan 2866345e8c remove a couple tooltips that render incorrectly 2024-05-03 10:40:08 -05:00
Ahmed Awan bb24c23650 [24.0] History Multiview panel shows pinned histories on top 
Fixes https://github.com/galaxyproject/galaxy/issues/18082
 2024-05-03 10:32:31 -05:00
Dannon Baker 97efceafce Explicitly specify that outputFormat is a string -- this fixes tsc getting confused below when reassigning 2024-04-26 11:25:55 -04:00