mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-09-24 16:30:27 +08:00
migrate US-006: test_history_storage.py
Remove @selenium_only from both tests. Fix wait_on bug in wait_for_history_to_have_hid where history_has_hid returned False (non-None) instead of None, causing wait_on to return immediately without polling on Playwright backend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
e04841dbf7
commit
f95bb56e6a
@@ -596,7 +596,9 @@ class NavigatesGalaxy(HasDriverProxy[WaitType]):
|
||||
|
||||
def history_has_hid(driver=None):
|
||||
hids = get_hids()
|
||||
return any(h == hid for h in hids)
|
||||
# Return True or None (not False) so wait_on keeps polling
|
||||
# wait_on treats any non-None value as success, including False
|
||||
return True if any(h == hid for h in hids) else None
|
||||
|
||||
timeout = self.wait_length(wait_type=WAIT_TYPES.JOB_COMPLETION)
|
||||
try:
|
||||
|
||||
@@ -1,6 +1,5 @@
|
||||
from .framework import (
|
||||
managed_history,
|
||||
selenium_only,
|
||||
selenium_test,
|
||||
SeleniumTestCase,
|
||||
)
|
||||
@@ -30,7 +29,6 @@ UPLOAD_DATA_3 = {
|
||||
class TestHistoryStorage(SeleniumTestCase):
|
||||
ensure_registered = True
|
||||
|
||||
@selenium_only("Not yet migrated to support Playwright backend")
|
||||
@selenium_test
|
||||
@managed_history
|
||||
def test_history_storage_accessibility(self):
|
||||
@@ -57,7 +55,6 @@ class TestHistoryStorage(SeleniumTestCase):
|
||||
self.screenshot("storage_dashboard_manage_explore_usage_landing")
|
||||
self.assert_baseline_accessibility()
|
||||
|
||||
@selenium_only("Not yet migrated to support Playwright backend")
|
||||
@selenium_test
|
||||
@managed_history
|
||||
def test_delete_dataset_from_storage_view(self):
|
||||
|
||||
Reference in New Issue
Block a user