Fix multipanel history search.

2026-09-24 16:30:27 +08:00 · 2019-06-04 11:46:24 -04:00
parent 9b9daffd41
commit edcce00aab
1 changed files with 6 additions and 3 deletions
@@ -835,7 +835,6 @@ var MultiPanelColumns = Backbone.View.extend(baseMVC.LoggableMixin).extend({
    /** Set up any view plugins */
    setUpBehaviors: function() {
        this._moreOptionsPopover();
-
        // input to search histories
        this.$("#search-histories").searchInput({
            name: "search-histories",
@@ -850,10 +849,14 @@ var MultiPanelColumns = Backbone.View.extend(baseMVC.LoggableMixin).extend({
                });
            },
            onsearch: searchFor => {
+                const multipanel = this;
                this.historySearch = searchFor;
                this.filters = [
-                    () => {
-                        return this.model.matchesAll(this.historySearch);
+                    function() {
+                        // This is intentionally a function where 'this' gets
+                        // bound, applying the filter to the model of the
+                        // caller.
+                        return this.model.matchesAll(multipanel.historySearch);
                    }
                ];
                this.renderColumns(0);