Consolidate code duplication of collection builders in data library

This commit is contained in:
guerler
2022-09-18 15:23:08 -04:00
parent 96bbe85603
commit d1e6908948
3 changed files with 4 additions and 4 deletions
@@ -36,7 +36,7 @@ function createListCollection(contents, defaultHideSourceItems = true) {
id: element.id,
name: element.name,
//TODO: this allows for list:list even if the filter above does not - reconcile
src: element.history_content_type === "dataset" ? "hda" : "hdca",
src: element.src || (element.history_content_type == "dataset" ? "hda" : "hdca"),
}));
copyElements = !hideSourceItems;
return contents.createHDCA(elements, "list", name, hideSourceItems, copyElements);
@@ -29,8 +29,8 @@ function createPairCollection(contents, defaultHideSourceItems = true) {
defaultHideSourceItems: defaultHideSourceItems,
creationFn: function (elements, name, hideSourceItems) {
elements = [
{ name: "forward", src: "hda", id: elements[0].id },
{ name: "reverse", src: "hda", id: elements[1].id },
{ name: "forward", src: elements[0].src || "hda", id: elements[0].id },
{ name: "reverse", src: elements[1].src || "hda", id: elements[1].id },
];
copyElements = !hideSourceItems;
return contents.createHDCA(elements, "paired", name, hideSourceItems, copyElements);
@@ -83,9 +83,9 @@ var ImportCollectionModal = Backbone.View.extend({
collection_item.name = dataset.name;
collection_item.deleted = dataset.deleted;
collection_item.state = dataset.state;
collection_item.src = "ldda";
collection_elements.push(collection_item);
}
const new_history_name = this.modal.$("input[name=history_name]").val();
if (new_history_name !== "") {
this.createNewHistory(new_history_name)