opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-19 10:51:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15320 from davelopez/fix_tool_shed_tests

Browse Source 
Revert check for new legacy API routes
This commit is contained in:
Marius van den Beek
2023-01-17 15:06:28 +01:00
committed by GitHub
parent 4178266659 8f0ecc6b7f
commit cf446dce5d
1 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/webapps/galaxy/fast_app.py
-17
View File
@@ -141,29 +141,12 @@ def include_legacy_openapi(app, gx_app):
tags=api_tags_metadata,
)
legacy_openapi = gx_app.api_spec.to_dict()
_check_legacy_openapi_does_not_increase(legacy_openapi)
legacy_openapi["paths"].update(openapi_schema["paths"])
openapi_schema["paths"] = legacy_openapi["paths"]
app.openapi_schema = openapi_schema
return app.openapi_schema
def _check_legacy_openapi_does_not_increase(legacy_openapi):
"""This will check that we don't keep adding legacy API routes to the codebase.
After migrating any legacy route to FastAPI, remember to update `expected_legacy_paths` with the current number
until all routes are migrated, then, completely remove this check function.
"""
expected_legacy_paths = 169
num_actual_legacy_paths = len(legacy_openapi["paths"])
assert (
num_actual_legacy_paths <= expected_legacy_paths
), "The number of legacy API routes has increased. Please convert these API routes to FastAPI."
assert (
num_actual_legacy_paths == expected_legacy_paths
), "Did you forget to update `expected_legacy_paths` after migrating legacy API routes?"
def get_fastapi_instance() -> FastAPI:
return FastAPI(
title="Galaxy API",