opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Unicodify has different semantics to str

Browse Source 
Originally my patch was written with str()'s behaviour in mind. If a value is None, it gets cast.
I did not test my patch well enough following @nsoranzo's request to replace with unicodify(). In that case a raw None gets passed to cgi.escape() causing a bug
This commit is contained in:
Eric Rasche
2016-05-10 15:24:07 +00:00
parent 74e6d8b5d8
commit cd3f28d8a7
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/tools/errors.py
+2 -1
View File
@@ -209,7 +209,8 @@ class ErrorReporter( object ):
# Escape all of the content for use in the HTML report
for parameter in report_variables.keys():
report_variables[parameter] = cgi.escape(unicodify(report_variables[parameter]))
if report_variables[parameter] is not None:
report_variables[parameter] = cgi.escape(unicodify(report_variables[parameter]))
self.html_report = string.Template( error_report_template_html ).safe_substitute( report_variables )