Simplify js loading -- yagni

This commit is contained in:
Dannon Baker
2020-01-23 13:01:59 -05:00
parent f169f4d486
commit cc7f7cfcda
3 changed files with 8 additions and 22 deletions
+2 -6
View File
@@ -52,13 +52,9 @@
## TODO: remove when all libs are required directly in modules
${h.dist_js(
'libs.chunk',
'base.chunk'
'base.chunk',
'generic.bundled'
)}
${self.javascript_entry()}
</%def>
<%def name="javascript_entry()">
${h.dist_js('generic.bundled')}
</%def>
<%def name="javascript_app()">
+2 -7
View File
@@ -35,14 +35,9 @@
<!--- base/base_panels.mako javascripts() -->
${h.dist_js(
'libs.chunk',
'base.chunk'
'base.chunk',
'generic.bundled'
)}
${ javascript_entry() }
</%def>
<%def name="javascript_entry()">
<!-- base/base_panels.mako javascript_entry -->
${ h.dist_js('generic.bundled')}
</%def>
<%def name="javascript_app()">
+4 -9
View File
@@ -53,7 +53,7 @@
<body scroll="no" class="full-content">
<div id="everything">
<div id="background"></div>
%if self.galaxy_config['master']:
@@ -177,20 +177,15 @@
<!-- galaxy.panels.mako javascripts -->
${h.dist_js(
'libs.chunk',
'base.chunk'
'base.chunk',
'generic.bundled'
)}
${self.javascript_entry()}
</%def>
<%def name="javascript_entry()">
<!-- galaxy.panels.mako javascript_entry -->
${h.dist_js('generic.bundled')}
</%def>
<%def name="javascript_app()">
<!-- galaxy.panels.mako javascript_app -->
<script type="text/javascript">
var galaxyConfig = ${ h.dumps( self.galaxy_config ) };
## TODO: Some visualizations (and more?) currently use this config, should be refactored.