Remove unused visualizations dropdown, fix dropdown for dataset options

This commit is contained in:
guerler
2019-05-01 17:12:36 -04:00
parent bcbdea6699
commit c81be7a71d
2 changed files with 9 additions and 46 deletions
@@ -467,41 +467,8 @@ DatasetListItemEdit.prototype.templates = (() => {
"dataset"
)
});
var visualizationsTemplate = BASE_MVC.wrapTemplate(
[
"<% if( visualizations.length === 1 ){ %>",
'<a class="visualization-link icon-btn" href="<%- visualizations[0].href %>"',
' target="<%- visualizations[0].target %>" title="',
_l("Visualize in"),
' <%- visualizations[0].html %>">',
'<span class="fa fa-bar-chart-o"></span>',
"</a>",
"<% } else { %>",
'<div class="visualizations-dropdown dropdown icon-btn">',
'<a data-toggle="dropdown" title="',
_l("Visualize"),
'">',
'<span class="fa fa-bar-chart-o"></span>',
"</a>",
'<ul class="dropdown-menu" role="menu">',
"<% _.each( visualizations, function( visualization ){ %>",
'<li><a class="visualization-link" href="<%- visualization.href %>"',
' target="<%- visualization.target %>">',
"<%- visualization.html %>",
"</a></li>",
"<% }); %>",
"</ul>",
"</div>",
"<% } %>"
],
"visualizations"
);
return _.extend({}, _super.prototype.templates, {
warnings: warnings,
visualizations: visualizationsTemplate
warnings: warnings
});
})();
@@ -323,22 +323,18 @@ export var DatasetListItemView = _super.extend(
)}">
<span class="fa fa-floppy-o"></span>
</a>
<ul class="dropdown-menu" role="menu">
<li>
<a href="${urls.download}">
${_l("Download dataset")}
</a>
</li>
<div class="dropdown-menu" role="menu">
<a class="dropdown-item" href="${urls.download}">
${_l("Download dataset")}
</a>
${_.map(
this.model.get("meta_files"),
meta_file =>
`<li>
<a href="${urls.meta_download + meta_file.file_type}">
${_l("Download")} ${meta_file.file_type}
</a>
</li>`
`<a class="dropdown-item" href="${urls.meta_download + meta_file.file_type}">
${_l("Download")} ${meta_file.file_type}
</a>`
)}
</ul>
</div>
</div>`);
},