Merge pull request #6743 from martenson/fix-favicon-uwsgi

[18.09] fix favicon.ico for uwsgi deployments

config/galaxy.yml.sample

@@ -47,6 +47,9 @@ uwsgi:
   # Mapping to serve the remainder of the static content.
   static-map: /static=static
 
+  # Mapping to serve the favicon.
+  static-map: /favicon.ico=static/favicon.ico
+
   # Enable the master process manager. Disabled by default for maximum
   # compatibility with CTRL+C, but should be enabled for use with
   # --daemon and/or production deployments.

config/reports.yml.sample

@@ -29,6 +29,9 @@ uwsgi:
   # Mapping to serve the remainder of the static content.
   static-map: /static=static
 
+  # Mapping to serve the favicon.
+  static-map: /favicon.ico=static/favicon.ico
+
   # Enable the master process manager. Disabled by default for maximum
   # compatibility with CTRL+C, but should be enabled for use with
   # --daemon and/or production deployments.

config/tool_shed.yml.sample

@@ -29,6 +29,9 @@ uwsgi:
   # Mapping to serve the remainder of the static content.
   static-map: /static=static
 
+  # Mapping to serve the favicon.
+  static-map: /favicon.ico=static/favicon.ico
+
   # Enable the master process manager. Disabled by default for maximum
   # compatibility with CTRL+C, but should be enabled for use with
   # --daemon and/or production deployments.

lib/galaxy/webapps/config_manage.py

@@ -85,6 +85,12 @@ UWSGI_OPTIONS = OrderedDict([
         'default': '/static=static',
         'type': 'str',
     }),
+    ('static-map.3', {
+        'key': 'static-map',
+        'desc': """Mapping to serve the favicon.""",
+        'default': '/favicon.ico=static/favicon.ico',
+        'type': 'str',
+    }),
     ('master', {
         'desc': """Enable the master process manager. Disabled by default for maximum compatibility with CTRL+C, but should be enabled for use with --daemon and/or production deployments.""",
         'default': False,

scripts/get_uwsgi_args.py

@@ -91,7 +91,8 @@ def _get_uwsgi_args(cliargs, kwargs):
         'buffer-size': '16384',  # https://github.com/galaxyproject/galaxy/issues/1530
         'http': 'localhost:{port}'.format(port=DEFAULT_PORTS[cliargs.app]),
         'static-map': ('/static/style={here}/static/style/blue'.format(here=os.getcwd()),
-                       '/static={here}/static'.format(here=os.getcwd())),
+                       '/static={here}/static'.format(here=os.getcwd()),
+                       '/favicon.ico={here}/static/favicon.ico'.format(here=os.getcwd())),
         'static-safe': ('{here}/config/plugins/visualizations'.format(here=os.getcwd()),
                         '{here}/config/plugins/interactive_environments'.format(here=os.getcwd())),
         'die-on-term': True,