opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add error checking for public username. Username must have between 3 and 255 characters and be unique.

Browse Source
This commit is contained in:
Jeremy Goecks
2010-02-04 10:44:36 -05:00
parent d9d7a29840
commit b4e815fb49
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/web/controllers/user.py
+21 -2
View File
@@ -327,6 +327,19 @@ class User( BaseController ):
elif trans.sa_session.query( trans.app.model.User ).filter_by(email=email).all():
error = "User with that email already exists"
return error
def __validate_username(self, trans, params, username, user=None):
error = None
if user:
if user.username == username:
return None
if len( username ) < 3:
error = "Username must be at least 3 characters long"
elif len( username ) > 255:
error = "Username cannot be more than 255 characters"
elif trans.sa_session.query( trans.app.model.User ).filter_by( username=username ).all():
error = "User with that username already exists"
return error
def __validate_password(self, trans, params, password, confirm):
error = None
if len(password) < 6:
@@ -482,10 +495,16 @@ class User( BaseController ):
# Editing login info (email & username)
#
if params.get('login_info_button', None) == 'Save':
email = util.restore_text( params.get('email', '') )
username = util.restore_text( params.get('username', '') )
email = util.restore_text( params.get('email', '') ).lower()
username = util.restore_text( params.get('username', '') ).lower()
# validate the new values
error = self.__validate_email(trans, params, email, user)
if error:
return trans.response.send_redirect( web.url_for( controller='user',
action='show_info',
msg=error,
messagetype='error') )
error = self.__validate_username( trans, params, username, user )
if error:
return trans.response.send_redirect( web.url_for( controller='user',
action='show_info',