opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Delete dead legacy tag controller

Browse Source 
The `tag_autocomplete_data`, `add_tag_async`, and `remove_tag_async`
endpoints served a long-removed jQuery/YUI autocomplete widget and have
zero non-self references in the codebase. Modern tagging uses
`PUT /api/tags` (`FastAPITags.update`).
This commit is contained in:
mvdbeek
2026-04-11 12:24:01 +02:00
parent 349a5daec1
commit b3f54e5553
2 changed files with 0 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files
doc/source/lib/galaxy.webapps.galaxy.controllers.rst
-8
View File
@@ -105,14 +105,6 @@ galaxy.webapps.galaxy.controllers.shed\_tool\_static module
:undoc-members:
:show-inheritance:
galaxy.webapps.galaxy.controllers.tag module
--------------------------------------------
.. automodule:: galaxy.webapps.galaxy.controllers.tag
:members:
:undoc-members:
:show-inheritance:
galaxy.webapps.galaxy.controllers.tool\_runner module
-----------------------------------------------------
lib/galaxy/webapps/galaxy/controllers/tag.py
-181
View File
@@ -1,181 +0,0 @@
"""
Tags Controller: handles tagging/untagging of entities
and provides autocomplete support.
"""
import logging
from sqlalchemy.sql import select
from sqlalchemy.sql.expression import (
and_,
func,
)
from galaxy import web
from galaxy.model import Tag
from galaxy.webapps.base.controller import (
BaseUIController,
UsesTagsMixin,
)
log = logging.getLogger(__name__)
class TagsController(BaseUIController, UsesTagsMixin):
@web.expose
@web.require_login("add tag to an item")
def add_tag_async(self, trans, item_id=None, item_class=None, new_tag=None, context=None, **kwargs):
"""
Add tag to an item.
"""
# Apply tag.
item = self._get_item(trans, item_class, trans.security.decode_id(item_id))
user = trans.user
trans.tag_handler.apply_item_tags(user, item, new_tag)
trans.sa_session.commit()
# Log.
params = dict(item_id=item.id, item_class=item_class, tag=new_tag)
trans.log_action(user, "tag", context, params)
@web.expose
@web.require_login("remove tag from an item")
def remove_tag_async(self, trans, item_id=None, item_class=None, tag_name=None, context=None, **kwargs):
"""
Remove tag from an item.
"""
# Remove tag.
item = self._get_item(trans, item_class, trans.security.decode_id(item_id))
user = trans.user
trans.tag_handler.remove_item_tag(user, item, tag_name)
trans.sa_session.commit()
# Log.
params = dict(item_id=item.id, item_class=item_class, tag=tag_name)
trans.log_action(user, "untag", context, params)
@web.expose
@web.require_login("get autocomplete data for an item's tags")
def tag_autocomplete_data(self, trans, q=None, limit=None, timestamp=None, item_id=None, item_class=None, **kwargs):
"""
Get autocomplete data for an item's tags.
"""
# Get item, do security check, and get autocomplete data.
item = None
if item_id is not None:
item = self._get_item(trans, item_class, trans.security.decode_id(item_id))
user = trans.user
item_class = self.get_class(item_class)
q = "" if q is None else q
if q.find(":") == -1:
return self._get_tag_autocomplete_names(trans, q, limit, timestamp, user, item, item_class)
else:
return self._get_tag_autocomplete_values(trans, q, limit, timestamp, user, item, item_class)
def _get_tag_autocomplete_names(self, trans, q, limit, timestamp, user=None, item=None, item_class=None):
"""
Returns autocomplete data for tag names ordered from most frequently used to
least frequently used.
"""
# Get user's item tags and usage counts.
# Get item's class object and item-tag association class.
if item is None and item_class is None:
raise RuntimeError("Both item and item_class cannot be None")
elif item is not None:
item_class = item.__class__
item_tag_assoc_class = trans.tag_handler.get_tag_assoc_class(item_class)
# Build select statement.
from_obj = item_tag_assoc_class.table.join(item_class.table).join(Tag.table)
where_clause = and_(Tag.table.c.name.like(f"{q}%"), item_tag_assoc_class.table.c.user_id == user.id)
# Do query and get result set.
query = (
select(item_tag_assoc_class.table.c.tag_id, func.count())
.select_from(from_obj)
.where(where_clause)
.group_by(item_tag_assoc_class.table.c.tag_id)
.order_by(func.count().desc())
.limit(limit)
)
result_set = trans.sa_session.execute(query)
# Create and return autocomplete data.
ac_data = "#Header|Your Tags\n"
for row in result_set:
tag = trans.tag_handler.get_tag_by_id(row[0])
# Exclude tags that are already applied to the item.
if (item is not None) and (trans.tag_handler.item_has_tag(trans.user, item, tag)):
continue
# Add tag to autocomplete data. Use the most frequent name that user
# has employed for the tag.
tag_names = self._get_usernames_for_tag(trans, trans.user, tag, item_class, item_tag_assoc_class)
ac_data += f"{tag_names[0]}|{tag_names[0]}\n"
return ac_data
def _get_tag_autocomplete_values(self, trans, q, limit, timestamp, user=None, item=None, item_class=None):
"""
Returns autocomplete data for tag values ordered from most frequently used to
least frequently used.
"""
tag_name_and_value = q.split(":")
tag_name = tag_name_and_value[0]
tag_value = tag_name_and_value[1]
tag = trans.tag_handler.get_tag_by_name(tag_name)
# Don't autocomplete if tag doesn't exist.
if tag is None:
return ""
# Get item's class object and item-tag association class.
if item is None and item_class is None:
raise RuntimeError("Both item and item_class cannot be None")
elif item is not None:
item_class = item.__class__
item_tag_assoc_class = trans.tag_handler.get_tag_assoc_class(item_class)
# Build select statement.
from_obj = item_tag_assoc_class.table.join(item_class.table).join(Tag.table)
where_clause = and_(
item_tag_assoc_class.table.c.user_id == user.id,
Tag.table.c.id == tag.id,
item_tag_assoc_class.table.c.value.like(f"{tag_value}%"),
)
# Do query and get result set.
query = (
select(item_tag_assoc_class.table.c.value, func.count())
.select_from(from_obj)
.where(where_clause)
.group_by(item_tag_assoc_class.table.c.value)
.order_by(func.count().desc(), item_tag_assoc_class.table.c.value)
.limit(limit)
)
result_set = trans.sa_session.execute(query)
# Create and return autocomplete data.
ac_data = f"#Header|Your Values for '{tag_name}'\n"
tag_uname = self._get_usernames_for_tag(trans, trans.user, tag, item_class, item_tag_assoc_class)[0]
for row in result_set:
ac_data += f"{tag_uname}:{row[0]}|{row[0]}\n"
return ac_data
def _get_usernames_for_tag(self, trans, user, tag, item_class, item_tag_assoc_class):
"""
Returns an ordered list of the user names for a tag; list is ordered from
most popular to least popular name.
"""
# Build select stmt.
where_clause = and_(
item_tag_assoc_class.table.c.user_id == user.id, item_tag_assoc_class.table.c.tag_id == tag.id
)
# Do query and get result set.
query = (
select(item_tag_assoc_class.table.c.user_tname, func.count())
.where(where_clause)
.group_by(item_tag_assoc_class.table.c.user_tname)
.order_by(func.count().desc())
)
result_set = trans.sa_session.execute(query)
user_tag_names = []
for row in result_set:
user_tag_names.append(row[0])
return user_tag_names
def _get_item(self, trans, item_class_name, id):
"""
Get an item based on type and id.
"""
item_class = trans.tag_handler.item_tag_assoc_info[item_class_name].item_class
item = trans.sa_session.query(item_class).filter(item_class.id == id)[0]
return item