opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Also perform strict checks for new database objects

Browse Source 
I think that's the missing piece to find all the instances where we
might still be committing HDAs without HIDs, and I think we might have
a similar bug for DatasetCollectionElements.
This commit is contained in:
mvdbeek
2024-04-21 21:10:51 +02:00
parent 8f4968f02a
commit b1333e01cf
1 changed files with 23 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/model/base.py
+23 -9
View File
@@ -174,18 +174,32 @@ def versioned_objects_strict(iter):
yield obj
if os.environ.get("GALAXY_TEST_RAISE_EXCEPTION_ON_HISTORYLESS_HDA"):
log.debug("Using strict flush checks")
versioned_objects = versioned_objects_strict # noqa: F811
def get_before_flush_handler():
if os.environ.get("GALAXY_TEST_RAISE_EXCEPTION_ON_HISTORYLESS_HDA"):
log.debug("Using strict flush checks")
def before_flush(session, flush_context, instances):
for obj in session.new:
if hasattr(obj, "__strict_check_before_flush__"):
obj.__strict_check_before_flush__()
for obj in versioned_objects_strict(session.dirty):
obj.__create_version__(session)
for obj in versioned_objects_strict(session.deleted):
obj.__create_version__(session, deleted=True)
else:
def before_flush(session, flush_context, instances):
for obj in versioned_objects(session.dirty):
obj.__create_version__(session)
for obj in versioned_objects(session.deleted):
obj.__create_version__(session, deleted=True)
return before_flush
def versioned_session(session):
@event.listens_for(session, "before_flush")
def before_flush(session, flush_context, instances):
for obj in versioned_objects(session.dirty):
obj.__create_version__(session)
for obj in versioned_objects(session.deleted):
obj.__create_version__(session, deleted=True)
event.listens_for(session, "before_flush")(get_before_flush_handler())
def ensure_object_added_to_session(object_to_add, *, object_in_session=None, session=None) -> bool: