mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-09-24 16:30:27 +08:00
Do not change list value to csv string
Remove side effect from strip_deprecated_dir function. For context, see code review.
This commit is contained in:
@@ -295,6 +295,10 @@ class BaseAppConfiguration:
|
||||
"to suppress this warning: %s", key, resolves_to, ignore, path
|
||||
)
|
||||
paths[i] = path[len(ignore):]
|
||||
|
||||
# return list or string, depending on type of `value`
|
||||
if isinstance(value, list):
|
||||
return paths
|
||||
return ','.join(paths)
|
||||
return value
|
||||
|
||||
|
||||
@@ -214,7 +214,7 @@ def test_kwargs_as_list_listify(mock_init, monkeypatch):
|
||||
new_path4 = ['new1', 'new2']
|
||||
config = BaseAppConfiguration(path4=new_path4)
|
||||
|
||||
assert config._raw_config['path4'] == 'new1,new2'
|
||||
assert config._raw_config['path4'] == ['new1', 'new2']
|
||||
assert config.path4 == ['my-config/new1', 'my-config/new2']
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user