opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18473 from ElectronicBlueberry/fix-workflow-relabel-noop

Browse Source 
[24.1] fix no-op workflow "relabel" shouldn't result in a notification
This commit is contained in:
Marius van den Beek
2024-07-03 12:40:31 +02:00
committed by GitHub
parent 922e2c8f4e 43bbe77eb7
commit 9c2b8ec39b
1 changed files with 22 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/Workflow/Editor/Actions/stepActions.ts
+22 -27
View File
@@ -54,6 +54,22 @@ export class LazyMutateStepAction<K extends keyof Step> extends LazyUndoRedoActi
}
}
function onLabelSet(
classInstance: LazySetLabelAction | LazySetOutputLabelAction,
from: string | null | undefined,
to: string | null | undefined
) {
const markdown = classInstance.stateStore.report.markdown ?? "";
const newMarkdown = replaceLabel(markdown, classInstance.labelType, from, to);
if (markdown !== newMarkdown) {
classInstance.stateStore.report.markdown = newMarkdown;
classInstance.success(
`${classInstance.labelTypeTitle} label updated from "${from}" to "${to}" in workflow report.`
);
}
}
export class LazySetLabelAction extends LazyMutateStepAction<"label"> {
labelType: "input" | "step";
labelTypeTitle: "Input" | "Step";
@@ -80,24 +96,13 @@ export class LazySetLabelAction extends LazyMutateStepAction<"label"> {
this.success = useToast().success;
}
private toast(from: string, to: string) {
this.success(`${this.labelTypeTitle} label updated from "${from}" to "${to}" in workflow report.`);
}
run() {
const markdown = this.stateStore.report.markdown ?? "";
const newMarkdown = replaceLabel(markdown, this.labelType, this.fromValue as string, this.toValue as string);
this.stateStore.report.markdown = newMarkdown;
this.toast(this.fromValue ?? "", this.toValue ?? "");
onLabelSet(this, this.fromValue, this.toValue);
}
undo() {
super.undo();
const markdown = this.stateStore.report.markdown ?? "";
const newMarkdown = replaceLabel(markdown, this.labelType, this.toValue as string, this.fromValue as string);
this.stateStore.report.markdown = newMarkdown;
this.toast(this.toValue ?? "", this.fromValue ?? "");
onLabelSet(this, this.toValue, this.fromValue);
}
redo() {
@@ -111,6 +116,8 @@ export class LazySetOutputLabelAction extends LazyMutateStepAction<"workflow_out
fromLabel;
toLabel;
stateStore;
labelType = "output" as const;
labelTypeTitle = "Output" as const;
constructor(
stepStore: WorkflowStepStore,
@@ -132,25 +139,13 @@ export class LazySetOutputLabelAction extends LazyMutateStepAction<"workflow_out
this.success = useToast().success;
}
private toast(from: string, to: string) {
this.success(`Output label updated from "${from}" to "${to}" in workflow report.`);
}
run() {
const markdown = this.stateStore.report.markdown ?? "";
const newMarkdown = replaceLabel(markdown, "output", this.fromLabel, this.toLabel);
this.stateStore.report.markdown = newMarkdown;
this.toast(this.fromLabel ?? "", this.toLabel ?? "");
onLabelSet(this, this.fromLabel, this.toLabel);
}
undo() {
super.undo();
const markdown = this.stateStore.report.markdown ?? "";
const newMarkdown = replaceLabel(markdown, "output", this.toLabel, this.fromLabel);
this.stateStore.report.markdown = newMarkdown;
this.toast(this.toLabel ?? "", this.fromLabel ?? "");
onLabelSet(this, this.toLabel, this.fromLabel);
}
redo() {