Disable galaxy tour 'path' navigation -- this style of tour nav behaves very poorly with Galaxy and it's pretty easy to get a tour completely *stuck* in reload loops from the user experience, forcing manual cache cleaning or the like to make Galaxy usable again.

This commit is contained in:
Dannon Baker
2018-01-18 17:12:45 -05:00
parent a48d0e9a7f
commit 7af6381e24
+11 -1
View File
@@ -34,7 +34,7 @@ Select any tour to get started (and remember, you can click 'End Tour' at any ti
<a href="/tours/<%- tour.id %>" class="tourItem" data-tour.id=<%- tour.id %>>
<%- tour.name || tour.id %>
</a>
- <%- tour.attributes.description || \"No description given.\" %>
- <%- tour.attributes.description || "No description given." %>
<% _.each(tour.attributes.tags, function(tag) { %>
<span class="label label-primary sm-label-pad">
<%- tag.charAt(0).toUpperCase() + tag.slice(1) %>
@@ -83,6 +83,16 @@ var hooked_tour_from_data = data => {
.trigger("change");
};
}
if (step.path) {
// Galaxy does *not* support automagic path navigation right now in
// Tours -- too many ways to get your client 'stuck' in automatic
// navigation loops. We can probably re-enable this as our client
// routing matures.
console.warn(
"This Galaxy Tour is attempting to use path navigation. This is known to be unstable and can possibly get the Galaxy client 'stuck' in a tour, and at this time is not allowed."
);
delete step.path;
}
});
return data;
};