opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Better type annotation of optional string parameters

Browse Source
This commit is contained in:
Nicola Soranzo
2021-11-25 13:37:43 +00:00
parent fe0f6e48e1
commit 7564325ac4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy_test/base/populators.py
+4 -4
View File
@@ -652,7 +652,7 @@ class BaseDatasetPopulator(BasePopulator):
history_id = create_history_response.json()["id"]
return history_id
def upload_payload(self, history_id: str, content: str = None, **kwds) -> dict:
def upload_payload(self, history_id: str, content: Optional[str] = None, **kwds) -> dict:
name = kwds.get("name", "Test_Dataset")
dbkey = kwds.get("dbkey", "?")
file_type = kwds.get("file_type", 'txt')
@@ -872,7 +872,7 @@ class BaseDatasetPopulator(BasePopulator):
assert "id" in role, role
return role["id"]
def create_role(self, user_ids: list, description: str = None) -> dict:
def create_role(self, user_ids: list, description: Optional[str] = None) -> dict:
payload = {
"name": self.get_random_name(prefix="testpop"),
"description": description or "Test Role",
@@ -1114,7 +1114,7 @@ class BaseWorkflowPopulator(BasePopulator):
workflow = self.load_workflow(name)
return self.create_workflow(workflow, **create_kwds)
def import_workflow_from_path_raw(self, from_path: str, object_id: str = None) -> Response:
def import_workflow_from_path_raw(self, from_path: str, object_id: Optional[str] = None) -> Response:
data = dict(
from_path=from_path,
object_id=object_id,
@@ -1122,7 +1122,7 @@ class BaseWorkflowPopulator(BasePopulator):
import_response = self._post("workflows", data=data)
return import_response
def import_workflow_from_path(self, from_path: str, object_id: str = None) -> str:
def import_workflow_from_path(self, from_path: str, object_id: Optional[str] = None) -> str:
import_response = self.import_workflow_from_path_raw(from_path, object_id)
api_asserts.assert_status_code_is(import_response, 200)
return import_response.json()["id"]