opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Strip dead test code (that actually threw an exception when enabled due to undefined variables).

Browse Source
This commit is contained in:
Dannon Baker
2013-03-05 16:07:35 -05:00
parent 9a4d211a9a
commit 5e297f3b67
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/security/__init__.py
-16
View File
@@ -903,26 +903,10 @@ class GalaxyRBACAgent( RBACAgent ):
.filter( and_( trans.app.model.DatasetPermissions.dataset_id.in_( dataset_ids ),
trans.app.model.DatasetPermissions.action == self.permitted_actions.DATASET_ACCESS.action ) ) \
.all()
# Every dataset returned has "access" privileges associated with it,
# so it's not public.
for permission in access_data_perms:
datasets_public[ permission.dataset_id ] = False
# Test code: Check if the results match up with the original:
test_code = False
if test_code:
log.debug( "datasets_are_public test: check datasets_are_public matches dataset_is_public:" )
test_success = True
for dataset in datasets:
orig_is_public = self.dataset_is_public( dataset )
if orig_is_public == datasets_public[ dataset.id ]:
log.debug( "\tMatch for dataset %d" % dataset.id )
else:
success = False
log.error( "\tERROR: Did not match: single is_public: %s; multiple is_public: %s"
% ( single_is_public, datasets_public[ dataset.id ] ) )
log.debug( "datasets_are_public: test succeeded? %s" % test_success )
return datasets_public