opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Better error message for unknown ShellJobRunner shell plugin

Browse Source 
Instead of raising:

```
  File "/srv/galaxy/lib/galaxy/jobs/runners/util/cli/__init__.py", line 78, in get_shell_plugin
    self.active_cli_shells[requested_shell_settings] = self.cli_shells[shell_plugin](**shell_params)
KeyError: 'ZecureShell'
```

raise:

```
  File "/srv/galaxy/lib/galaxy/jobs/runners/util/cli/__init__.py", line 80, in get_shell_plugin
    raise ValueError(f"Unknown shell_plugin [{shell_plugin}], available plugins are {list(self.cli_shells.keys())}")
ValueError: Unknown shell_plugin [ZecureShell], available plugins are ['RemoteShell', 'SecureShell', 'GlobusSecureShell', 'ParamikoShell', 'LocalShell']
```
This commit is contained in:
Nicola Soranzo
2021-12-02 18:55:02 +00:00
parent ee061229b8
commit 5d3648af92
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/jobs/runners/util/cli/__init__.py
+4 -1
View File
@@ -75,7 +75,10 @@ class CliInterface:
shell_plugin = shell_params.get('plugin', DEFAULT_SHELL_PLUGIN)
requested_shell_settings = json.dumps(shell_params, sort_keys=True)
if requested_shell_settings not in self.active_cli_shells:
self.active_cli_shells[requested_shell_settings] = self.cli_shells[shell_plugin](**shell_params)
shell_plugin_class = self.cli_shells.get(shell_plugin)
if not shell_plugin_class:
raise ValueError(f"Unknown shell_plugin [{shell_plugin}], available plugins are {list(self.cli_shells.keys())}")
self.active_cli_shells[requested_shell_settings] = shell_plugin_class(**shell_params)
return self.active_cli_shells[requested_shell_settings]
def get_job_interface(self, job_params):