opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid exception when opening apply rules tool and no collection in history

Browse Source 
Fixes https://sentry.galaxyproject.org/share/issue/97b5b9cfcef14ca0b59b851684170698/
```
AttributeError: 'NoneType' object has no attribute 'id'
  File "galaxy/tools/__init__.py", line 2601, in populate_model
    tool_dict = input.to_dict(request_context, other_values=other_values)
  File "galaxy/tools/parameters/basic.py", line 2648, in to_dict
    "id": trans.app.security.encode_id(target.id),
```

Which is in a try/except anyway, so fairly inconsequential, but results
in cleaner logs / one less sentry error.
This commit is contained in:
mvdbeek
2024-04-17 16:40:00 +02:00
parent 33538bea49
commit 5ce4986752
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/tools/parameters/basic.py
+1 -2
View File
@@ -2646,8 +2646,7 @@ class RulesListToolParameter(BaseJsonToolParameter):
def to_dict(self, trans, other_values=None):
other_values = other_values or {}
d = ToolParameter.to_dict(self, trans)
if (target_name := self.data_ref) in other_values:
target = other_values[target_name]
if target := other_values.get(self.data_ref):
if not is_runtime_value(target):
d["target"] = {
"src": "hdca" if hasattr(target, "collection") else "hda",