Prevent exception in toolshed if userid is 'current'

and the user is not already logged in (=trans.user is None).

Fixes https://sentry.galaxyproject.org/sentry/toolshed/issues/568664/
This commit is contained in:
mvdbeek
2020-03-22 14:54:25 +01:00
parent 69969e25a0
commit 52ceb8b23e
+1 -5
View File
@@ -106,11 +106,7 @@ class UsersController(BaseAPIController):
"""
user = None
# user is requesting data about themselves
if id == "current" and trans.user:
user = trans.user
else:
user = suc.get_user(trans.app, id)
user = trans.user if id == 'current' else suc.get_user(trans.app, id)
if user is None:
user_dict = dict(message='Unable to locate user record for id %s.' % (str(id)),
status='error')