removed bug with missing return

2026-09-24 16:30:27 +08:00 · 2014-09-16 13:15:32 -04:00
parent 3cc0b971d1
commit 4dbb249ca6
5 changed files with 8 additions and 5 deletions
@@ -592,13 +592,15 @@ var FolderToolbarView = Backbone.View.extend({
    // need to check which paths to call
    var that = this;
    var popped_item = paths.pop();
-    if (typeof popped_item === "undefined") {
+    if (typeof popped_item == "undefined") {
      if (this.options.chain_call_control.failed_number === 0){
        mod_toastr.success('Selected folders and their contents imported into the current folder');
        Galaxy.modal.hide();
      } else {
+        // TODO better error report
        mod_toastr.error('Something went wrong :(');
      }
+      return true;
    }
    var promise = $.when($.post('/api/libraries/datasets?encoded_folder_id=' + that.id +
                                                      '&source=' + source +
@@ -592,13 +592,14 @@ var FolderToolbarView = Backbone.View.extend({
    // need to check which paths to call
    var that = this;
    var popped_item = paths.pop();
-    if (typeof popped_item === "undefined") {
+    if (typeof popped_item == "undefined") {
      if (this.options.chain_call_control.failed_number === 0){
        mod_toastr.success('Selected folders and their contents imported into the current folder');
        Galaxy.modal.hide();
      } else {
        mod_toastr.error('Something went wrong :(');
      }
+      return true;
    }
    var promise = $.when($.post('/api/libraries/datasets?encoded_folder_id=' + that.id +
                                                      '&source=' + source +