migrate US-003: test_tutorial_mode.py

- remove @selenium_only from test_activate_tutorial_mode
- fix switch_to_frame to match iframes by id (not just name),
  matching Selenium's behavior
- fix stale element detection for Playwright's "not attached to the DOM"
- add switch_to_default_content after frame assertions for axe compat

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
John Chilton
2026-02-12 14:55:55 -05:00
co-authored by Claude Opus 4.6
parent caff5ba59e
commit 4775dff706
3 changed files with 18 additions and 11 deletions
+2 -1
View File
@@ -666,7 +666,8 @@ def exception_indicates_not_clickable(exception):
def exception_indicates_stale_element(exception):
return "stale" in str(exception)
exception_str = str(exception)
return "stale" in exception_str or "not attached to the DOM" in exception_str
__all__ = (
+15 -8
View File
@@ -849,16 +849,23 @@ class HasPlaywrightDriver(TimeoutMessageMixin, WaitMethodsMixin, Generic[WaitTyp
state to track the current frame.
"""
if isinstance(frame_reference, str):
# Find frame by name or id
# Try as name attribute first
# Find frame by name or id (matching Selenium's switch_to.frame behavior)
frame = self.page.frame(name=frame_reference)
if frame is None:
# Try as frame locator by name attribute selector
frame_locator = self.page.frame_locator(f"[name='{frame_reference}']")
# Store the frame locator for future use
self._current_frame = frame_locator
else:
if frame is not None:
self._current_frame = frame
else:
# Selenium also matches by id — locate the iframe element and
# resolve its content Frame so downstream code (axe_eval, etc.)
# gets a proper Frame object rather than a FrameLocator.
selector = f"iframe[name='{frame_reference}'], iframe[id='{frame_reference}']"
iframe_el = self.page.query_selector(selector)
if iframe_el is not None:
self._current_frame = iframe_el.content_frame()
else:
# Last resort: use a FrameLocator (limited API)
self._current_frame = self.page.frame_locator(
f"[name='{frame_reference}'], [id='{frame_reference}']"
)
elif isinstance(frame_reference, int):
# Get frame by index
frames = self.page.frames
@@ -3,14 +3,12 @@ from unittest import SkipTest
import pytest
from .framework import (
selenium_only,
selenium_test,
SeleniumTestCase,
)
class TestTutorialMode(SeleniumTestCase):
@selenium_only("Not yet migrated to support Playwright backend")
@selenium_test
@pytest.mark.gtn_screenshot
def test_activate_tutorial_mode(self):
@@ -24,6 +22,7 @@ class TestTutorialMode(SeleniumTestCase):
self.switch_to_frame("gtn-embed")
self.wait_for_selector_visible("#top-navbar")
self.screenshot("tutorial_mode_0_2")
self.switch_to_default_content()
def _ensure_tutorial_mode_available(self):
"""Skip a test if the webhook GTN doesn't appear."""