opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Modernize objectstore Optional annotations for ruff UP045

Browse Source
This commit is contained in:
Nuwan Goonasekera
2026-07-08 02:02:45 +05:30
parent 05c726109c
commit 439f5d25ea
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/objectstore/__init__.py
+7 -7
View File
@@ -321,8 +321,8 @@ class ObjectStore(metaclass=abc.ABCMeta):
@abc.abstractmethod
def get_direct_download_url(
self, obj, content_disposition: Optional[str] = None, content_type: Optional[str] = None
) -> Optional[str]:
self, obj, content_disposition: str | None = None, content_type: str | None = None
) -> str | None:
"""Return a URL a client can be redirected to in order to download `obj` directly from the backing store.
Returns None unless the concrete store supports direct access *and* the admin has opted in via the
@@ -687,13 +687,13 @@ class BaseObjectStore(ObjectStore):
)
def get_direct_download_url(
self, obj, content_disposition: Optional[str] = None, content_type: Optional[str] = None
) -> Optional[str]:
self, obj, content_disposition: str | None = None, content_type: str | None = None
) -> str | None:
return self._invoke(
"get_direct_download_url", obj, content_disposition=content_disposition, content_type=content_type
)
def _get_direct_download_url(self, obj, content_disposition=None, content_type=None) -> Optional[str]:
def _get_direct_download_url(self, obj, content_disposition=None, content_type=None) -> str | None:
# Stores that don't support direct download (or haven't opted in) get this no-op default.
return None
@@ -824,7 +824,7 @@ class ConcreteObjectStore(BaseObjectStore):
object_expires_after_days=self.object_expires_after_days,
)
def _get_direct_download_url(self, obj, content_disposition=None, content_type=None) -> Optional[str]:
def _get_direct_download_url(self, obj, content_disposition=None, content_type=None) -> str | None:
if not self.enable_direct_download:
return None
# _get_object_url is resolved via dynamic dispatch on each concrete backend; it is not
@@ -1301,7 +1301,7 @@ class NestedObjectStore(BaseObjectStore):
"""For the first backend that has this `obj`, get its URL."""
return self._call_method("_get_object_url", obj, None, False, **kwargs)
def _get_direct_download_url(self, obj, content_disposition=None, content_type=None) -> Optional[str]:
def _get_direct_download_url(self, obj, content_disposition=None, content_type=None) -> str | None:
"""For the first backend that has this `obj`, get its direct download URL."""
return self._call_method(
"_get_direct_download_url",