opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

More robust is_beta_history() check.

Browse Source 
Given error on https://github.com/galaxyproject/galaxy/runs/6068791674?check_suite_focus=true, I assume what happened is the beta history panel wasn't on the page so the test tried to act on the old history panel.
This commit is contained in:
John Chilton
2022-04-19 12:13:55 -04:00
parent ed1c4c2ef0
commit 3aeeb47e8d
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/selenium/navigates_galaxy.py
+10 -1
View File
@@ -1435,7 +1435,16 @@ class NavigatesGalaxy(HasDriver):
self.components.history_panel.beta.wait_for_present()
def is_beta_history(self):
return not self.components.history_panel.beta.is_absent
old_panel = self.components.history_panel.beta.is_absent
new_panel = self.components.history_panel.new_history_button.is_absent
if old_panel and new_panel:
# both absent, let page render a bit...
self.sleep_for(self.wait_types.UX_RENDER)
else:
return new_panel
old_panel = self.components.history_panel.beta.is_absent
return not old_panel
# avoids problematic ID and classes on markup
def beta_history_element(self, attribute_value, attribute_name="data-description", scope=".history-index"):