opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling in DirectoryUriToolParameter validation

Browse Source 
Avoids 500 status code if the parameter has a wrong value
This commit is contained in:
davelopez
2021-10-21 19:07:58 +02:00
parent 31e6b32221
commit 2fd861bf89
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/tools/parameters/basic.py
+4 -1
View File
@@ -2419,7 +2419,10 @@ class DirectoryUriToolParameter(SimpleTextToolParameter):
super().validate(value, trans=trans)
if not value:
return # value is not set yet, do not validate
file_source = trans.app.file_sources.get_file_source_path(value).file_source
file_source_path = trans.app.file_sources.get_file_source_path(value)
file_source = file_source_path.file_source
if file_source is None:
raise ParameterValueError(f"'{value}' is not a valid file source uri.", self.name)
user_context = ProvidesUserFileSourcesUserContext(trans)
user_has_access = file_source.user_has_access(user_context)
if not user_has_access: