opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use tool_version instead of version parameter

Browse Source 
To be consistent with other routes that accept this parameter.
This commit is contained in:
mvdbeek
2018-09-13 20:30:52 +02:00
parent d1352c4b27
commit 17d148eb8f
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/galaxy/webapps/galaxy/api/tools.py
+3 -3
View File
@@ -94,12 +94,12 @@ class ToolsController(BaseAPIController, UsesVisualizationMixin):
io_details - if true, parameters and inputs are returned
link_details - if true, hyperlink to the tool is returned
version - if provided return this tool version
tool_version - if provided return this tool version
"""
io_details = util.string_as_bool(kwd.get('io_details', False))
link_details = util.string_as_bool(kwd.get('link_details', False))
version = kwd.get('version')
tool = self._get_tool(id, user=trans.user, tool_version=version)
tool_version = kwd.get('tool_version')
tool = self._get_tool(id, user=trans.user, tool_version=tool_version)
return tool.to_dict(trans, io_details=io_details, link_details=link_details)
@expose_api_anonymous
test/api/test_tools.py
+4 -4
View File
@@ -142,10 +142,10 @@ class ToolsTestCase(api.ApiTestCase):
assert output_details["state"] == "error", output_details
assert "has not sent back a URL parameter" in output_details["misc_info"], output_details
def _show_valid_tool(self, tool_id, version=None):
def _show_valid_tool(self, tool_id, tool_version=None):
data = dict(io_details=True)
if version:
data['version'] = version
if tool_version:
data['tool_version'] = tool_version
tool_show_response = self._get("tools/%s" % tool_id, data=data)
self._assert_status_code_is(tool_show_response, 200)
tool_info = tool_show_response.json()
@@ -522,7 +522,7 @@ class ToolsTestCase(api.ApiTestCase):
@skip_without_tool("multiple_versions")
@uses_test_history(require_new=False)
def test_show_with_wrong_tool_version_in_tool_id(self, history_id):
tool_info = self._show_valid_tool("multiple_versions", version="0.01")
tool_info = self._show_valid_tool("multiple_versions", tool_version="0.01")
# Return last version
assert tool_info['version'] == "0.2"