Remove exported prop type interfaces in JobMetrics and CarbonEmissions components

This commit is contained in:
Rendani Gangazhe
2023-06-02 10:08:18 -04:00
committed by Dannon Baker
parent 9913a49bba
commit 13e99c52b7
5 changed files with 32 additions and 28 deletions
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { computed } from "vue";
export interface AwsEstimateProps {
const props = defineProps<{
jobRuntimeInSeconds: number;
coresAllocated: number;
memoryAllocatedInMebibyte?: number;
@@ -18,9 +18,7 @@ export interface AwsEstimateProps {
source: string;
}[];
}[];
}
const props = defineProps<AwsEstimateProps>();
}>();
const computedAwsEstimate = computed(() => {
const { coresAllocated, jobRuntimeInSeconds, memoryAllocatedInMebibyte } = props;
@@ -2,14 +2,12 @@
import { ref } from "vue";
import CarbonEmissionsIcon from "./CarbonEmissionsIcon.vue";
export interface CarbonEmissionsCardProps {
const props = defineProps<{
heading: string;
explanation: string;
value: string | number;
icon: InstanceType<typeof CarbonEmissionsIcon>["$props"]["icon"];
}
const props = defineProps<CarbonEmissionsCardProps>();
}>();
const shouldShowInfo = ref(false);
@@ -10,7 +10,7 @@ import * as carbonEmissionsConstants from "./carbonEmissionConstants.js";
library.add(faQuestionCircle);
export interface CarbonEmissionsProps {
interface CarbonEmissionsProps {
estimatedServerInstance: {
name: string;
cpuInfo: {
@@ -14,11 +14,9 @@ import { library } from "@fortawesome/fontawesome-svg-core";
library.add(faBolt, faCar, faGasPump, faLightbulb, faMobile, faSmog, faTree, faTruck);
export interface CarbonEmissionsIconProps {
const props = defineProps<{
icon: "bolt" | "car" | "gasPump" | "lightbulb" | "mobilePhone" | "smog" | "tree";
}
const props = defineProps<CarbonEmissionsIconProps>();
}>();
</script>
<template>
+25 -15
View File
@@ -4,21 +4,31 @@ import CarbonEmissions from "./CarbonEmissions/CarbonEmissions.vue";
import { useJobMetricsStore } from "@/stores/jobMetricsStore";
import { computed, ref, unref } from "vue";
export interface JobMetricsProps {
datasetFilesize?: number;
datasetId?: string;
datasetType?: string;
includeTitle?: boolean;
jobId: string;
shouldShowAwsEstimate?: boolean;
}
const props = withDefaults(defineProps<JobMetricsProps>(), {
datasetFilesize: 0,
datasetId: "",
datasetType: "hda",
includeTitle: true,
shouldShowAwsEstimate: false,
const props = defineProps({
jobId: {
type: String,
required: true,
},
datasetFilesize: {
type: Number,
default: 0,
},
datasetId: {
type: String,
default: "",
},
datasetType: {
type: String,
default: "hda",
},
includeTitle: {
type: Boolean,
default: true,
},
shouldShowAwsEstimate: {
type: Boolean,
default: false,
},
});
const jobMetricsStore = useJobMetricsStore();