opensource/filament
3
0
Fork 0
mirror of https://github.com/filamentphp/filament.git synced 2026-09-24 15:42:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8567 from fouteox/patch-2

Browse Source 
Update helpers.php
This commit is contained in:
Dan Harrin
2023-09-18 08:57:50 +01:00
committed by GitHub
parent b86fa17c0f ac4505610c
commit 94d17b2ff5
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/support/src/helpers.php
+2 -4
View File
@@ -119,12 +119,10 @@ if (! function_exists('Filament\Support\generate_href_html')) {
{
$html = "href=\"{$url}\"";
if (FilamentView::hasSpaMode() && str($url)->startsWith(request()->root())) {
$html .= ' wire:navigate';
}
if ($shouldOpenInNewTab) {
$html .= ' target="_blank"';
} elseif (FilamentView::hasSpaMode() && str($url)->startsWith(request()->root())) {
$html .= ' wire:navigate';
}
return new HtmlString($html);
tests/src/Support/SpaModeTest.php
+1 -1
View File
@@ -40,7 +40,7 @@ test('`wire:navigate` is not used in the `href` HTML if it doesn\'t match the re
test('`target` HTML can be generated if the URL should open in a new tab', function () {
FilamentView::spa();
expect(generate_href_html('http://localhost/page', shouldOpenInNewTab: true))
->toHtml()->toBe('href="http://localhost/page" wire:navigate target="_blank"');
->toHtml()->toBe('href="http://localhost/page" target="_blank"');
FilamentView::spa(false);
expect(generate_href_html('http://localhost/page', shouldOpenInNewTab: true))