opensource/filament
3
0
Fork 0
mirror of https://github.com/filamentphp/filament.git synced 2026-10-13 09:26:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: wait for wizard requests without focus scripts or sleeps

Browse Source 
Use native Playwright actions and observable loading state. Let delayed requests finish before continuing or tearing down, and retain the dark-mode page.
This commit is contained in:
Dan Harrin
2026-10-11 08:52:58 +00:00
parent 6765bf57e9
commit 892d05d59e
2 changed files with 29 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/Fixtures/Pages/WizardBrowserTest.php
+1 -1
View File
@@ -46,7 +46,7 @@ class WizardBrowserTest extends Page
->key('details')
->id('profile-details')
->beforeValidation(static function (): void {
delay(1);
delay(3);
})
->schema([
WizardBrowserTestSelect::make('status')
tests/src/Schemas/Components/WizardTest.php
+28 -31
View File
@@ -743,20 +743,16 @@ it('only shows the next action loading indicator for its own request', function
$browser = visit('/wizard-browser-test')
->click('[data-testid="wizard-dynamic-select"] .fi-select-input-btn')
->wait(0.3);
->assertAttribute(":has(> {$nextAction})", 'aria-disabled', 'true')
->assertMissing($nextActionLoadingIndicator)
->click('Draft')
->assertAttributeMissing(":has(> {$nextAction})", 'aria-disabled');
expect($browser->script(
"document.querySelector('{$nextAction}').parentElement.getAttribute('aria-disabled')",
))->toBe('true');
expect($browser->script(
"Boolean(document.querySelector('{$nextActionLoadingIndicator}')?.getClientRects().length)",
))->toBeFalse();
$browser->page()->locator($nextAction)->click();
$browser
->click('Draft')
->click($nextAction)
->assertVisible($nextActionLoadingIndicator)
->assertVisible('#profile-contact')
->assertNoSmoke();
});
@@ -769,39 +765,40 @@ it('keeps the next action focused and blocked during other requests', function (
$browser = visit('/wizard-browser-test');
if ($isDarkMode) {
$browser->inDarkMode();
$browser = $browser->inDarkMode();
}
$browser->script(<<<'JS'
document.querySelector('[data-testid="wizard-next-action"]').focus()
document.querySelector('[data-testid="wizard-dynamic-select"] .fi-select-input-btn').click()
JS);
$nextActionLocator = $browser->page()->locator($nextAction);
$browser->wait(0.3);
$browser
->click('[data-testid="wizard-dynamic-select"] .fi-select-input-btn')
->assertAttribute(":has(> {$nextAction})", 'aria-disabled', 'true');
expect($browser->script(
"document.querySelector('{$nextAction}').parentElement.getAttribute('aria-disabled')",
))->toBe('true');
$nextActionLocator->press('Enter');
$nextActionLocator->press('Space');
$browser
->assertPresent("{$nextAction}:focus")
->keys($nextAction, 'Enter')
->keys($nextAction, 'Space')
->wait(0.1)
->assertScript('window.wizardNextActionActivationCount ?? 0', 0)
->assertAttributeMissing(":has(> {$nextAction})", 'aria-disabled')
->assertVisible('#profile-details')
->assertNoSmoke()
->wait(1)
->keys('[data-testid="wizard-dynamic-select"] .fi-select-input-btn', 'Escape')
->assertNoAccessibilityIssues()
->click($nextAction)
->assertNoAccessibilityIssues();
$nextActionLocator->click();
$browser
->assertAttribute($nextAction, 'aria-disabled', 'true')
->assertPresent("{$nextAction}:focus")
->keys($nextAction, 'Enter')
->keys($nextAction, 'Space')
->assertPresent("{$nextAction}:focus");
$nextActionLocator->press('Enter');
$nextActionLocator->press('Space');
$browser
->assertScript('window.wizardNextActionActivationCount', 1)
->wait(1.1)
->assertVisible('#profile-contact');
->assertVisible('#profile-contact')
->assertAttributeMissing(":has(> {$nextAction})", 'aria-disabled')
->assertNoSmoke();
}
});