opensource/filament
3
0
Fork 0
mirror of https://github.com/filamentphp/filament.git synced 2026-09-24 15:42:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: drop down cannot be expanded with the keyboard (#19275)

Browse Source 
* chore: fix code style

* fix: drop down cannot be expanded with the keyboard

---------

Co-authored-by: pjotrvdh <pjotrvdh@users.noreply.github.com>
This commit is contained in:
Pjotr van der Horst
2026-02-19 10:00:36 +00:00
committed by GitHub
co-authored by pjotrvdh
parent 8700f20dd3
commit 4cef47099a
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/actions/src/ActionGroup.php
+3 -1
View File
@@ -521,7 +521,9 @@ class ActionGroup extends ViewComponent implements Arrayable, HasEmbeddedView
<?= $this->getExtraDropdownAttributeBag()->class(['fi-dropdown'])->toHtml() ?>
>
<div
x-on:mousedown="toggle"
x-on:keyup.enter="toggle($event)"
x-on:keyup.space="toggle($event)"
x-on:mousedown="if ($event.button === 0) toggle($event)"
class="fi-dropdown-trigger"
>
<?= $this->toTriggerHtml() ?>
tests/src/Tables/GroupingTest.php
+8 -8
View File
@@ -1,6 +1,6 @@
<?php
use Filament\Tables;
use Filament\Tables\Grouping\Group;
use Filament\Tests\Fixtures\Livewire\GroupedCustomDataTable;
use Filament\Tests\Fixtures\Livewire\PostsTable;
use Filament\Tests\Fixtures\Livewire\UsersTable;
@@ -44,7 +44,7 @@ it('can group a table', function (): void {
$table = $livewire->getTable();
expect($table)
->getGrouping()->toBeInstanceOf(Tables\Grouping\Group::class)
->getGrouping()->toBeInstanceOf(Group::class)
->and($table->getGrouping())
->getLabel()->toBe('Dynamic label');
});
@@ -506,7 +506,7 @@ it('can group records with nullable `BelongsTo` -> `HasOneThrough` relationship'
it('can handle array records in `getKey()`', function (): void {
$livewire = livewire(PostsTable::class)->instance();
$group = \Filament\Tables\Grouping\Group::make('status')->table($livewire->getTable());
$group = Group::make('status')->table($livewire->getTable());
$arrayRecord = ['__key' => '1', 'name' => 'John', 'status' => 'active'];
@@ -515,7 +515,7 @@ it('can handle array records in `getKey()`', function (): void {
it('can handle array records in `getStringKey()`', function (): void {
$livewire = livewire(PostsTable::class)->instance();
$group = \Filament\Tables\Grouping\Group::make('status')->table($livewire->getTable());
$group = Group::make('status')->table($livewire->getTable());
$arrayRecord = ['__key' => '1', 'name' => 'John', 'status' => 'active'];
@@ -524,7 +524,7 @@ it('can handle array records in `getStringKey()`', function (): void {
it('can handle array records in `getTitle()`', function (): void {
$livewire = livewire(PostsTable::class)->instance();
$group = \Filament\Tables\Grouping\Group::make('status')->table($livewire->getTable());
$group = Group::make('status')->table($livewire->getTable());
$arrayRecord = ['__key' => '1', 'name' => 'John', 'status' => 'active'];
@@ -533,7 +533,7 @@ it('can handle array records in `getTitle()`', function (): void {
it('can handle array records in `getDescription()`', function (): void {
$livewire = livewire(PostsTable::class)->instance();
$group = \Filament\Tables\Grouping\Group::make('status')
$group = Group::make('status')
->getDescriptionFromRecordUsing(fn (array $record): string => 'User: ' . $record['name'])
->table($livewire->getTable());
@@ -544,7 +544,7 @@ it('can handle array records in `getDescription()`', function (): void {
it('can use custom `getKeyFromRecordUsing()` with array records', function (): void {
$livewire = livewire(PostsTable::class)->instance();
$group = \Filament\Tables\Grouping\Group::make('status')
$group = Group::make('status')
->getKeyFromRecordUsing(fn (array $record): string => strtoupper($record['status']))
->table($livewire->getTable());
@@ -556,7 +556,7 @@ it('can use custom `getKeyFromRecordUsing()` with array records', function (): v
it('can use custom `getTitleFromRecordUsing()` with array records', function (): void {
$livewire = livewire(PostsTable::class)->instance();
$group = \Filament\Tables\Grouping\Group::make('status')
$group = Group::make('status')
->getTitleFromRecordUsing(fn (array $record): string => 'Status: ' . ucfirst($record['status']))
->table($livewire->getTable());