opensource/filament
3
0
Fork 0
mirror of https://github.com/filamentphp/filament.git synced 2026-09-24 15:42:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR #8392 trim in getTableSearch(), preserving a null if present

Browse Source
This commit is contained in:
Jason Judge
2023-09-11 00:00:13 +01:00
parent f569d3dad0
commit 3cafad8b84
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/tables/src/Concerns/CanSearchRecords.php
+2 -2
View File
@@ -113,7 +113,7 @@ trait CanSearchRecords
protected function applyGlobalSearchToTableQuery(Builder $query): Builder
{
$search = trim($this->getTableSearch());
$search = $this->getTableSearch();
if (blank($search)) {
return $query;
@@ -149,7 +149,7 @@ trait CanSearchRecords
*/
public function getTableSearch()
{
return $this->tableSearch;
return $this->tableSearch === null ? null : trim($this->tableSearch);
}
public function hasTableSearch(): bool
tests/src/Tables/Concerns/CanSearchRecordsTest.php
+15
View File
@@ -33,3 +33,18 @@ it('can split on whitespace', function () {
$this->assertSame(['', 'test', ''], $trait->extractTableSearchWords(' test '));
});
it('can trim a search query', function () {
$trait = new class {
use \Filament\Tables\Concerns\CanSearchRecords;
};
$trait->tableSearch = 'test';
$this->assertSame('test', $trait->getTableSearch());
$trait->tableSearch = ' test ';
$this->assertSame('test', $trait->getTableSearch());
$trait->tableSearch = null;
$this->assertNull($trait->getTableSearch());
});