mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
Andrew Aquino
3e2a8bd421
fixes DEVEX-70 ## Summary Fixes #22350. `getAppHref()` in `site/src/modules/apps/apps.ts` called `new URL(app.url)` unguarded for external apps. When a template author configures a `coder_app` with an unparseable `url` (e.g. a bare string like `"my-repo"` with no scheme), `new URL()` threw `TypeError: Failed to construct 'URL': Invalid URL` during render. Because `getAppHref` runs inside `useAppLink` (used by both `AppLink` and the workspaces table `IconAppLink`), the exception crashed the entire Workspace List and Workspace detail pages, not just the affected app button. ## Changes - `getAppHref()` no longer throws: the external-app protocol parse is wrapped in `try/catch`, so an unparseable URL falls back to the raw value instead of crashing. - Added `isExternalAppUrlInvalid(app)`, a pure predicate used by consumers to decide whether the app can be launched. - `AppLink` renders a disabled button with a warning icon and an explanatory tooltip when the URL is invalid, mirroring the existing "admin has not configured subdomain application access" pattern. The tooltip points the user at the responsible configuration: > This app has an invalid URL and can't be opened. Ask your template administrator to fix the app's `url` in the template's `coder_app` configuration. - `IconAppLink` (workspaces table) renders a non-navigating icon with an equivalent label for invalid URLs. ## Testing - Unit tests in `apps.test.ts`: `getAppHref` no longer throws for invalid URLs, plus coverage of `isExternalAppUrlInvalid`. - New `InvalidExternalAppUrl` Storybook story with a `play` function asserting the button is disabled and the tooltip explains the invalid URL. - `pnpm exec vitest run` (unit + storybook), `pnpm exec tsc --noEmit`, and `biome check` all pass. <details> <summary>Implementation plan</summary> # Plan: Handle invalid `coder_app` URLs gracefully (issue #22350) ## Problem `getAppHref()` in `site/src/modules/apps/apps.ts` calls `new URL(app.url)` unguarded for external apps. When a template author sets an external app with an unparseable `url` (e.g. a bare string like `"my-repo"` with no scheme), `new URL()` throws during render. Because `getAppHref` runs inside `useAppLink` (called during render of `AppLink` and `IconAppLink`), the exception propagates and crashes the entire Workspace List and Workspace detail pages, not just the single app button. ## Goal Never throw from `getAppHref`. Detect the invalid-URL case and let the UI render a disabled button with an explanatory tooltip, mirroring the existing `isAppBlockedByMissingWildcard` pattern. ## Approach 1. Make `getAppHref` non-throwing (defensive), so no render path can crash. 2. Add a pure predicate `isExternalAppUrlInvalid(app)` used by button components to decide whether to disable and what tooltip to show. 3. Wire the predicate into `AppLink` and `IconAppLink`. ## Changes - `apps.ts`: wrap the external protocol parse in `try/catch`; add `isExternalAppUrlInvalid`. - `AppLink.tsx`: disabled state with `text-content-warning` icon and a `ReactNode` (React Fragment) tooltip with `url` and `coder_app` wrapped in inline `<code>` elements. - `WorkspacesTable.tsx` (`IconAppLink`): render a non-navigating icon when the URL is invalid. ## Tests - `apps.test.ts`: `getAppHref` does not throw for invalid URLs; predicate coverage. - `AppLink.stories.tsx`: `InvalidExternalAppUrl` story with a `play` function asserting disabled button and tooltip. ## Out of scope Backend/template-side validation of `coder_app.url` would prevent the misconfiguration at its source; tracked by the parent epic (#22349 / DEVEX-60). </details> --- *Opened by Coder Agents on behalf of @aqandrew.*
Coder is a self-hosted platform for cloud development environments and AI coding agents. Workspaces are defined with Terraform, connected through a secure Wireguard® tunnel, and automatically shut down when not used. Coder Agents runs a native AI coding agent whose loop executes in the control plane on your infrastructure, with no API keys in workspaces.
- Define cloud development environments in Terraform
- EC2 VMs, Kubernetes Pods, Docker Containers, etc.
- Automatically shutdown idle resources to save on costs
- Onboard developers in seconds instead of days
- Delegate coding work to AI agents on your infrastructure
- Bring any model (Anthropic, OpenAI, Google, Bedrock, self-hosted)
- No LLM credentials in workspaces, user identity on every action
- Centralized model governance, cost tracking, and audit logging
Quickstart
The most convenient way to try Coder is to install it on your local machine and experiment with provisioning cloud development environments using Docker (works on Linux, macOS, and Windows).
# First, install Coder
curl -L https://coder.com/install.sh | sh
# Start the Coder server (caches data in ~/.cache/coder)
coder server
# Navigate to http://localhost:3000 to create your initial user,
# create a Docker template and provision a workspace
Install
The easiest way to install Coder is to use the
install script for Linux
and macOS. For Windows, use the latest ..._installer.exe file from GitHub
Releases.
curl -L https://coder.com/install.sh | sh
You can run the install script with --dry-run to see the commands that will be used to install without executing them. Run the install script with --help for additional flags.
See install for additional methods.
Once installed, you can start a production deployment with a single command:
# Automatically sets up an external access URL on *.try.coder.app
coder server
# Requires a PostgreSQL instance (version 13 or higher) and external access URL
coder server --postgres-url <url> --access-url <url>
Use coder --help to get a list of flags and environment variables. See the install guides for a complete tutorial.
Documentation
Browse the documentation or visit a specific section below:
- Workspaces: Workspaces contain the IDEs, dependencies, and configuration information needed for software development
- Templates: Templates are written in Terraform and describe the infrastructure for workspaces
- Coder Agents: Delegate coding work to AI agents running on your self-hosted infrastructure
- Administration: Learn how to operate Coder
- Premium: Learn about paid features built for large teams
- IDEs: Connect your existing editor to a workspace
Support
Feel free to open an issue if you have questions, run into bugs, or have a feature request.
Join our Discord to provide feedback on in-progress features and chat with the community using Coder!
Integrations
New integrations are always in progress. Open an issue to request one. Contributions are welcome in any official or community repository.
Official
- Coder Registry: Templates, modules, and integrations for common development environments
- VS Code Extension: Open any Coder workspace in VS Code with a single click
- JetBrains Toolbox Plugin: Open any Coder workspace from JetBrains Toolbox with a single click
- JetBrains Gateway Plugin: Open any Coder workspace in JetBrains Gateway with a single click
- Dev Containers: Build development environments using
devcontainer.jsonon Docker, Kubernetes, and OpenShift - Kubernetes Log Stream: Stream Kubernetes Pod events to the Coder startup logs
- Self-Hosted VS Code Extension Marketplace: A private extension marketplace that works in restricted or airgapped networks integrating with code-server.
- GitHub Actions: An action to set up the Coder CLI in GitHub workflows
Community
- Community Templates: Community-contributed workspace templates in the Coder Registry
- Community Modules: Community-contributed modules to extend Coder templates
- Provision Coder with Terraform: Provision Coder on Google GKE, Azure AKS, AWS EKS, DigitalOcean DOKS, IBMCloud K8s, OVHCloud K8s, and Scaleway K8s Kapsule with Terraform
- Coder Template GitHub Action: A GitHub Action that updates Coder templates
- Discord: Chat with the community and provide feedback on in-progress features
Contributing
New contributors are always welcome. If you are new to the Coder codebase, see the contribution guide to get started.
Hiring
Apply on the careers page if you are interested in joining the team.