Vincent Vielle
ccbb687ca0
feat(cli): extend duration to longer units ( #15040 )
...
This PR is a proposal to improve the situation described in #14750
For some precise commands - we would like to be able to use durations
bigger than hours, minutes..
This PR extends the Duration proposed by Go with :
- `d` - a day or 24hours.
- `y` - a year or 365 days.
I also removed the default value for lifetime and instead fetch the
maxLifetime value from codersdk - so by default if no value set we use
the value defined in the config.
2024-10-16 17:02:56 +02:00
Steven Masley
774c9ddc64
test: add logging to TestWorkspaceActivityBump/Dial ( #15089 )
...
Added logging information to output timing information of this for
loop. If we get another failure, this timing information should be
helpful.
I also made the time drift allowed (was 10s) to match the maximum
waiting time of the for loop. It's not perfect, but now the loop should
take max ~15s, and the time comparison will allow 15s leeway.
2024-10-16 10:01:48 -05:00
Marcin Tojek
416d67ba2c
test: use barrier in TestInflightDispatchesMetric ( #15107 )
...
Fixes: https://github.com/coder/internal/issues/109
2024-10-16 14:12:19 +02:00
Marcin Tojek
21feb42fc4
test: ignore slog errors in TestUserLatencyInsights ( #15105 )
2024-10-16 13:20:28 +02:00
Spike Curtis
d676ad56fe
chore: log provider stack traces on text file busy ( #15078 )
...
re: #14726
If we see "text file busy" in the errors while initializing terraform,
attempt to query the pprof endpoint set up by
https://github.com/coder/terraform-provider-coder/pull/295 and log at
CRITICAL.
---------
Signed-off-by: Spike Curtis <spike@coder.com >
2024-10-16 14:29:09 +04:00
Spike Curtis
a77c9079af
fix: pin shfmt to 3.7.0 in dogfood to match CI ( #15103 )
...
Pins our dogfood Dockerfile to match CI version of `shfmt`
2024-10-16 14:17:27 +04:00
Marcin Tojek
2564f9c823
test: scaletest/reconnectingpty: use TerminalReader ( #15079 )
...
Fixes: https://github.com/coder/internal/issues/98
2024-10-16 11:10:32 +02:00
Spike Curtis
687b4dd41c
fix: match go version in go.mod and CI ( #15104 )
...
Causing CI to re-download Go to match the version in go.mod, and failing
on Windows, e.g.
https://github.com/coder/coder/actions/runs/11361195564/job/31600881001
2024-10-16 12:23:48 +04:00
Cian Johnston and Edward Angert
29763b1b4c
chore(docs): add notes regarding provisioner tags and untagged jobs ( #15081 )
...
Relates to https://github.com/coder/coder/issues/15047
---------
Co-authored-by: Edward Angert <EdwardAngert@users.noreply.github.com >
2024-10-16 09:22:39 +01:00
Sas Swart
75b5d71216
fix(docs): fix a typo in the devcontainer documentation ( #15102 )
...
This PR fixes a minor typo in our documentation:
https://coder.com/docs/admin/templates/managing-templates/devcontainers
2024-10-16 10:05:31 +02:00
Sas Swart
fac77f956e
fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed ( #15067 )
...
This PR closes #15065 .
As advised by @mtojek, a template's display name may be set to "", which
is not useful in an email notification. We'd like to provide a friendly
name for the template, but it also needs to be identifiable.
As such, we fall back to template.Name in the case that the template's
display name is empty.
2024-10-15 21:02:02 +02:00
dependabot[bot]
5317c500c8
ci: bump aquasecurity/trivy-action from 0.25.0 to 0.27.0 in the github-actions group ( #15061 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 23:28:04 +05:00
dependabot[bot]
cc0b264d36
chore: bump google.golang.org/api from 0.199.0 to 0.200.0 ( #15063 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 23:27:22 +05:00
Cian Johnston
06a40185cb
chore(examples): add missing devcontainer templates to examples.go ( #15080 )
2024-10-15 17:26:42 +01:00
Cian Johnston
89ff48744c
chore(docs): fix broken or missing links ( #15085 )
...
Fixes a number of TODOs and broken links.
2024-10-15 16:50:49 +01:00
Vincent Vielle
42e2a4150c
fix(coderd): improve workspace tests ( #15069 )
...
With [a recent PR](https://github.com/coder/coder/pull/14923 ) we
introduced [new
tests](https://github.com/coder/coder/pull/14923/files#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b )
that - while running in parallel to the existing ones - are failing.
This PR is a quick proposal to fix it - tested in local and in the CI to
unblock the situation. We can ignore it to work on a longer term
solution if preferred.
2024-10-15 16:30:38 +02:00
Bruno Quaresma
b8420ecaaf
test(coderd): fix flake on TestWorkspaceBuildTimings ( #15077 )
...
Fix https://github.com/coder/coder/issues/15073
2024-10-15 09:43:39 -03:00
Marcin Tojek
1523d935b5
test: skip scaletest/reconnectingpty Test_Runner ( #15076 )
...
Related: https://github.com/coder/internal/issues/98
2024-10-15 12:40:22 +00:00
Marcin Tojek
c6396e3125
test: skip scaletest/reconnectingpty Test_Runner ( #15075 )
...
Related: https://github.com/coder/internal/issues/98
2024-10-15 14:07:45 +02:00
Spike Curtis
17f2584318
fix: add psmock to gen and make-fresh targets ( #15072 )
...
Fixes
```
+ make -j build/coder_linux_amd64 build/coder_linux_arm64 build/coder_linux_armv7 build/coder_2.16.0-devel+7da231bc9_windows_amd64.zip build/coder_2.16.0-devel+7da231bc9_linux_amd64.tar.gz build/coder_2.16.0-devel+7da231bc9_linux_amd64.deb
coderd/database/pubsub/psmock/doc.go:4: running "mockgen": exec: "mockgen": executable file not found in $PATH
make: *** [Makefile:569: coderd/database/pubsub/psmock/psmock.go] Error 1
```
during builds.
2024-10-15 08:49:26 +00:00
Spike Curtis
3565227d02
chore: disable erroneous linting of function names in vpn ( #15055 )
...
Disables bogus linting e.g. https://github.com/coder/coder/actions/runs/11305350065/job/31444754200?pr=15011
2024-10-15 11:45:56 +04:00
Jon Ayers
7da231bc92
fix: fix error handling to prevent spam in proc prio management ( #15071 )
2024-10-15 02:17:10 +00:00
Jon Ayers
384873a114
feat: add wsproxy implementation for key fetching ( #14917 )
2024-10-14 20:04:10 +01:00
Stephen Kirby and Muhammad Atif Ali
531565645f
chore(docs): make version support more explicit ( #14785 )
...
Co-authored-by: Muhammad Atif Ali <atif@coder.com >
2024-10-14 18:05:25 +00:00
88c6a75d48
docs: reorganize and edit docs README ( #14706 )
...
Edit the docs readme for consistency and better flow
---------
Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com >
Co-authored-by: Muhammad Atif Ali <atif@coder.com >
2024-10-14 13:39:54 -04:00
Muhammad Atif Ali
57a65c15bf
chore: use commit sha for GitHub actions ( #15019 )
...
Use specific commit SHAs for GitHub actions across various workflows to
enhance reliability and reproducibility. This change ensures that
actions run against a known version, reducing the risk of unexpected
issues due to updates in the third-party action repositories.
This contributes to improving the score in #14879
2024-10-14 08:49:55 -07:00
Sas Swart
208ed1efd7
chore(coderd/notifications): expand golden file testing for notifications ( #15032 )
...
This PR aims to close https://github.com/coder/coder/issues/14913 .
It expands the golden files for the notifier to include the entire
payload serialised as JSON.
2024-10-14 12:34:32 +00:00
Bruno Quaresma
9c8ecb82a3
feat(coderd): return agent script timings ( #14923 )
...
Add the agent script timings into the
`/workspacebuilds/:workspacebuild/timings` response.
Close https://github.com/coder/coder/issues/14876
2024-10-14 09:31:03 -03:00
Phorcys
79d24d2101
feat: allow for different docker socket path in docker-based templates ( #15035 ) ( #15049 )
...
This PR fixes #15035 , I have tested it on my instance and it works as
expected.
2024-10-12 21:35:52 +02:00
dependabot[bot]
3eb2b5573b
chore: bump github.com/jedib0t/go-pretty/v6 from 6.5.0 to 6.6.0 ( #15007 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 11:47:34 +00:00
dependabot[bot]
914ce1b43a
chore: bump protobufjs from 7.2.5 to 7.4.0 in /site ( #14951 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 16:41:58 +05:00
dependabot[bot]
0fe4650c7a
chore: bump the vite group across 1 directory with 3 updates ( #14898 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 16:40:28 +05:00
dependabot[bot]
61287dc60c
chore: bump github.com/tidwall/gjson from 1.17.0 to 1.18.0 ( #15003 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 16:40:09 +05:00
dependabot[bot]
dee694ca46
chore: bump github.com/aws/aws-sdk-go-v2 from 1.31.0 to 1.32.2 ( #15046 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 16:39:44 +05:00
dependabot[bot]
bb8c7e7e35
chore: bump github.com/aws/smithy-go from 1.21.0 to 1.22.0 ( #15004 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 16:39:30 +05:00
dependabot[bot]
23b1515514
chore: bump github.com/open-policy-agent/opa from 0.68.0 to 0.69.0 ( #15010 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 04:39:10 -07:00
dependabot[bot]
6cc1b975e5
chore: bump github.com/valyala/fasthttp from 1.55.0 to 1.56.0 ( #15008 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 04:38:59 -07:00
dependabot[bot]
bac4fcb73b
chore: bump github.com/prometheus/common from 0.59.1 to 0.60.0 ( #15009 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 11:36:00 +00:00
dependabot[bot]
994e807140
chore: bump the react group across 2 directories with 1 update ( #14946 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-12 16:25:29 +05:00
Muhammad Atif Ali
20b3f8fbf3
chore: use a smaller runner for e2e test ( #15034 )
...
We run our e2e-tests on a 16-core machine with `--max-workers=1`
Using a standard runner with 2 cores, the machine runs the tests in the
same amount of time while reducing the cost 8 times.
Update: `test-e2e` fails on the 2core-8GB runner, so using a 4-core-16GB runner for that.
2024-10-12 11:23:13 +00:00
Joobi S B
191449078c
feat: implement feature to support template version while creating workspace using cli ( #14880 )
2024-10-11 18:00:11 +05:00
Vincent Vielle
0ef5340d20
fix: change message when trying to update a workspace already up-to-date ( #14975 )
...
Related to #14940 -
We replace the wording from Workspace isn't outdated to Workspace is
up-to-date when the workspace already is up-to-date.
2024-10-10 12:56:53 +02:00
Muhammad Atif Ali
ab6cb1a787
docs: fix links for revere-proxy docs ( #15026 )
2024-10-10 05:31:19 +00:00
Sas Swart
9d02269191
feat(coderd/notifications): improve notification format consistency ( #14967 )
...
This Pull request addresses the more trivial items in
https://github.com/coder/coder/issues/14893 .
These were simple formatting changes that I was able to fix despite
limited context.
Some more changes are required for which I will have to dig a bit deeper
into how the template contexts are populated. I'm happy to add those to
this PR or create a subsequent PR.
2024-10-09 17:31:12 -05:00
Joobi S B
26df33ac88
docs: explain --rich-parameter-file format ( #14941 )
2024-10-09 09:34:24 +05:00
dependabot[bot]
a0787b71a1
chore: bump gopkg.in/DataDog/dd-trace-go.v1 from 1.67.0 to 1.68.0 ( #15005 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-08 09:13:45 +05:00
dependabot[bot] and Muhammad Atif Ali
71d31713c5
ci: bump the github-actions group across 1 directory with 2 updates ( #15016 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Muhammad Atif Ali <atif@coder.com >
2024-10-08 09:04:43 +05:00
dependabot[bot]
93e3c868eb
chore: bump google.golang.org/api from 0.197.0 to 0.199.0 ( #15006 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-08 08:58:55 +05:00
dependabot[bot]
a33c38d46d
chore: bump the x group with 6 updates ( #15001 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-08 08:33:00 +05:00
Muhammad Atif Ali
5afd022443
chore(README.md): add setup coder GitHub action link ( #14991 )
2024-10-08 08:10:59 +05:00