opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-10-29 17:44:33 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,560 Commits 479 Branches 417 Tags
ac559f101e49346e78cb7ea35ee91a0ea2d18180
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kyle CarberryandMathias Fredriksson 98164f687e fix!: remove startup logs eof for streaming (#8528) 
* fix: remove startup logs eof for streaming

We have external utilities like logstream-kube that may send
logs after an agent shuts down unexpectedly to report additional
information. In a recent change we stopped accepting these logs,
which broke these utilities.

In the future we'll rename startup logs to agent logs or something
more generalized so this is less confusing in the future.

* fix(cli/cliui): handle never ending startup log stream in Agent

---------

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
 2023-07-18 09:57:29 -06:00
Kyle Carberry b4a7fe3221 fix: use expires_in field for git device refresh (#8411) 
This was causing git auth to never refresh after the token
became expired after 8hrs.
 2023-07-11 09:28:52 +00:00
Kyle Carberry 34467a3289 feat: add github device flow for authentication (#8232) 
* feat: add github device flow for authentication

This will allow us to add a GitHub OAuth provider out-of-the-box
to reduce setup requirements.

* Improve askpass view

* Add routes to improve clarity of git auth

* Redesign the git auth page

* Refactor to add a page view

* Fix sideways layout

* Remove legacy notify

* Fix git auth redirects

* Add E2E tests

* Fix route documentation

* Fix imports

* Remove unused imports

* Fix E2E web test

* Fix friendly message appearance

* Fix layout shifting for full-screen sign-in

* Fix height going to 100%

* Fix comments
 2023-06-29 18:58:01 +00:00
Kyle Carberry f40865bc2f chore: use mutex around blockEndpoints (#8209) 
https://github.com/coder/coder/actions/runs/5378950122/jobs/9759972142
 2023-06-26 10:01:50 -05:00
Kyle Carberry d434181941 feat: add cohesive e2e tests for the web terminal, apps, and workspaces (#8140) 
* feat: add cohesive e2e tests for the web terminal, apps, and workspaces

* Fix web terminal flake
 2023-06-22 00:21:40 +00:00
Kyle Carberry 2a492b7008 chore: improve the setup experience with various fixes (#8130) 
* Move updatecheck logs to debug mode

This was causing logs to be emitted immediately after
initial setup, which seemed odd for the user.

* Fix setup page text to say "Create" instead of "Setup" account

* Improve copy on the empty workspaces page

- This view can be seen after the user creates their first workspace, so saying first is bad.
- It should describe what a workspace is, so I modified the description.
- The create from template button wasn't helpful!

* Improve the copy for the empty templates view

- This didn't describe what a template actually is.
- The title had the same problem as workspaces, where first makes no sense.

* Improve text consistency on the Create Template page

* Fix "View activity" displaying for non-Enterprise users

This was causing an exception to be thrown.

* Improve messaging of empty groups view

* Appropriately capitalize Workspace and Template

* Improve Docker template taglines

* Fix types
 2023-06-21 18:23:59 -05:00
Kyle Carberry 69f911dfd5 feat: add queue_position and queue_size to provisioner jobs (#8074) 2023-06-20 15:07:18 -05:00
Kyle Carberry bbb0fab1de chore: merge database gen scripts (#8073) 
* chore: merge database gen scripts

* Fix type params gen

* Merge enum into dbgen
 2023-06-20 16:24:33 +00:00
Kyle Carberry f3b2009499 chore: reorder helm chart to improve ux (#8108) 
It makes no sense that the primary option `env` was so far
below infrequently used options.
 2023-06-20 16:23:56 +00:00
Kyle Carberry 467b0a1004 chore: restyle provisioner job output format (#8106) 
Reduce colors and formatting to reduce bugs and increase UNIX-feel.
 2023-06-20 16:16:27 +00:00
Kyle Carberry f444100aa6 feat: add region querying to pre-fetched html (#8077) 2023-06-19 11:23:26 -05:00
Kyle CarberryandMuhammad Atif Ali 5b9c3784bc docs: add steps for registering a github app with coder (#7976) 
Co-authored-by: Muhammad Atif Ali <atif@coder.com>
 2023-06-18 14:01:37 -05:00
Kyle Carberry 9df9ad4503 feat: embed common client requests into the template html (#8076) 
This should reduce the number of API requests a client makes
when loading the dashboard dramatically!
 2023-06-18 13:57:27 -05:00
Kyle Carberry 2a10c9127f fix: show git provider id instead of type (#8075) 
Fixes #6343.
 2023-06-18 17:01:44 +00:00
Kyle Carberry 8ac68c95a4 chore: lazily initialize find commands in makefile (#8030) 
Improves make performance for small targets!
 2023-06-14 13:17:16 -05:00
Kyle Carberry e4b6f5695b chore: separate pubsub into a new package (#8017) 
* chore: rename store to dbmock for consistency

* chore: remove redundant dbtype package

This wasn't necessary and forked how we do DB types.

* chore: separate pubsub into a new package

This didn't need to be in database and was bloating it.
 2023-06-14 15:34:54 +00:00
Kyle Carberry 8c4b7c01e2 chore: remove redundant dbtype package (#8014) 
* chore: rename store to dbmock for consistency

* chore: remove redundant dbtype package

This wasn't necessary and forked how we do DB types.
 2023-06-13 19:14:55 +00:00
Kyle Carberry 7d54fd5e0d chore: rename store to dbmock for consistency (#8013) 2023-06-13 13:57:43 -05:00
Kyle Carberry a658c94a67 chore: automatically generate dbauthz when new queries are added (#8007) 
* chore: automatically generate dbauthz when new queries are added

* Merge system functions
 2023-06-13 13:40:46 -05:00
Kyle Carberry 794a551176 chore: generate dbmetrics automatically when adding new queries (#7999) 
* chore: rename dbgen package files and remove small file

* chore: automatically generate dbmetrics when new queries are added
 2023-06-13 12:35:12 -05:00
Kyle Carberry 2e7e99b135 fix: scope errors to subtests for flake (#8004) 
See: https://github.com/coder/coder/actions/runs/5257676837/jobs/9500882394
 2023-06-13 11:52:17 -05:00
Kyle Carberry 24953869a6 chore: remove key comparison check to fix gitsshkey flake (#8002) 
In tests we use weak randomness and the same key was generated which
caused a test flake here.
 2023-06-13 15:51:45 +00:00
Kyle Carberry 75078fafa2 chore: try removing cache from fmt and lint (#8001) 2023-06-13 10:48:53 -05:00
Kyle Carberry 9440b3da66 chore: rename dbgen package files and remove small file (#7997) 2023-06-13 09:21:12 -05:00
Kyle Carberry 28f35393e7 chore: generate and order dbfake funcs automatically (#7986) 
* chore: rename `databasefake` to `dbfake`

* Remove unused method

* chore: add generation to dbfake

* Auto gen on make gen

* Fix preserving imports

* gen dbfake

* Add goimports

* Fix the makefile

* Make it panic instead of a comment
 2023-06-12 17:40:58 -05:00
Kyle Carberry 685abfc6d7 chore: rename databasefake to dbfake (#7979) 
* chore: rename `databasefake` to `dbfake`

* Remove unused method
 2023-06-12 16:05:37 -05:00
Kyle Carberry 6ac7d86c93 chore: prevent gen from rerunning every time (#7985) 2023-06-12 14:45:17 -05:00
Kyle Carberry 6e7175b589 chore: fix lengthy tests in psql (#7545) 
* chore: fix lengthy tests in psql

This was adding at a minimum 3mins to our psql tests!

* fix: automatically cancel tests on cleanup
 2023-05-17 11:26:53 -05:00
Kyle Carberry c6055c64be chore: improve input hover color (#7534) 2023-05-16 09:00:20 -03:00
Kyle Carberry 424f954b91 fix: use password style for session token auth (#7533) 2023-05-15 11:27:39 -05:00
Kyle Carberry a08e8a16ab chore: switch make test to use the standard go format (#7519) 
I find it easier to read.
 2023-05-14 21:20:19 -05:00
Kyle Carberry 70d2203b9e chore: reduce the log output of skipped tests (#7520) 
With the introduction of the workspace proxy tests there was a lot
of output if a test was eventually skipped.
 2023-05-14 19:37:00 -05:00
Kyle Carberry 26490aecca chore: improve postgres test time by removing cleanup (#7522) 
We don't need to delete databases on cleanup... and we don't need to
always run without a cache either!
 2023-05-14 15:32:44 -05:00
Kyle Carberry 778cb7494a chore: adjust the style and wording of the license page (#7396) 
- Reduce the size of the card to improve the use of space
- Adjust the language of the add page to remove word redundancy
- Change from using background colors to text colors
 2023-05-14 15:31:54 -05:00
Kyle Carberry 8e1da5e628 chore: run yarn-deduplicate to speed up yarn install (#7523) 2023-05-14 15:28:07 -05:00
Kyle Carberry 50f2d0c7e9 fix: add a mutex around reading logs from scaletests (#7521) 2023-05-14 12:16:00 -05:00
Kyle Carberry 11ac3be4d8 fix: redirect to login on gitauth invalid session (#7416) 2023-05-04 17:19:44 +00:00
Kyle Carberry 90c57a538c fix: make telemetry source a string not an enum (#7390) 2023-05-03 14:33:51 +00:00
Kyle CarberryandMathias Fredriksson fd84df769d fix: add DISPLAY env var for X11 connections (#7248) 
* fix: add `DISPLAY` env var for X11 connections

* Update agent/agentssh/agentssh.go

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

---------

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
 2023-04-21 16:43:49 +00:00
Kyle Carberry f39e6a79de feat: add support for X11 forwarding (#7205) 
* feat: add support for X11 forwarding

* Only run X forwarding on Linux

* Fix piping

* Fix comments
 2023-04-21 15:52:40 +00:00
Kyle Carberry 888eb238ec fix: use CODER_HTTP_ADDRESS in docker-compose.yml (#7185) 
Fixes #7184.
 2023-04-18 11:44:41 -05:00
Kyle Carberry 693e5d94bc fix: add global headers to vscodessh command (#7181) 2023-04-18 08:07:10 -05:00
Kyle Carberry 26cfc18b74 fix: use proper deployment access setting name (#7162) 2023-04-17 10:01:51 -05:00
Kyle Carberry d3356fa48e fix: upgrade terraform in apk (#7146) 2023-04-14 20:10:17 -05:00
Kyle Carberry 7f12020229 fix: remove irrelevant help info from coder tokens create (#7135) 
The additional text didn't help much, and made it much harder to script around.
 2023-04-14 12:18:01 -05:00
Kyle Carberry 0bbe1562f3 fix: adjust manifest for networking doc (#7136) 2023-04-14 09:36:23 -05:00
Kyle Carberry 81e2b2500a feat: add level support for startup logs (#7067) 
This allows external services like our devcontainer support to display
errors and warnings with custom styles to indicate failures to users.
 2023-04-10 14:29:59 -05:00
Kyle Carberry e1149992d8 feat: support ansi colors in startup script logs (#7037) 
This will help with beautiful output for devcontainers!
 2023-04-06 12:39:09 -05:00
Kyle Carberry c68ab7d9a8 fix: support X-Forwarded-Host with CODER_REDIRECT_TO_ACCESS_URL (#7035) 
Fixes #7026.
 2023-04-06 12:07:24 -05:00
Kyle Carberry 3ff2ae1b1a fix: output askpass to stderr (#7034) 
This fixes askpass not outputting a prompt.
 2023-04-06 11:32:43 -05:00
Kyle CarberryandColin Adler 385a4262e2 fix: remove audit-logging flag from the server (#6991) 
Co-authored-by: Colin Adler <colin1adler@gmail.com>
 2023-04-04 12:11:10 -05:00
Kyle Carberry c12bc39821 fix: always show a newly created workspace at the top of the list (#6984) 
Fixes #5795.
 2023-04-04 08:24:04 -05:00
Kyle Carberry 861d4afdd8 fix: update tailscale to remove websocket logs (#6981) 2023-04-03 16:28:49 +00:00
Kyle Carberry bc18f6c113 fix: add CODER_AGENT_TAILNET_LISTEN_PORT for specifying a static tailnet port (#6980) 
Fixes #5175.
 2023-04-03 16:20:19 +00:00
Kyle Carberry 4ee01dc95c fix: remove orphan rbac warning message (#6979) 
The request will fail if the user doesn't have permissions, so it seems
useless to output this.
 2023-04-03 11:15:56 -05:00
Kyle Carberry 55c0b26977 fix: update status text for the workspace progress bar (#6977) 
Fixes #4691.
 2023-04-03 11:00:56 -05:00
Kyle Carberry 2d051094e7 fix: ignore deleted workspaces in global stats (#6973) 
Fixes #6568.
 2023-04-03 14:46:09 +00:00
Kyle Carberry 84956c16cc fix: reduce spacing when agent metadata doesn't exist (#6937) 2023-03-31 22:08:42 +00:00
Kyle Carberry cd807bc0c8 fix: delete old addresses from the active derp mesh mapping (#6926) 2023-03-31 14:25:01 +00:00
Kyle Carberry b5f5740d0b chore: ensure agent conn routine is closed before exit (#6900) 
This caused a leak in `main`!
 2023-03-30 17:20:14 +00:00
Kyle Carberry e496bdb687 chore: update slog to fix local leak with http.Transport (#6899) 2023-03-30 12:13:15 -05:00
Kyle Carberry a63c97b8de chore: wrap audit logs in a mutex to fix data race (#6898) 
This was seen in `main`!
 2023-03-30 12:13:03 -05:00
Kyle Carberry 5780006adb chore: use http-swagger/v2 for go:embed to reduce binary size (#6897) 
I'm testing how much this will reduce the size, but it should
be by a few MB!
 2023-03-30 16:46:58 +00:00
Kyle Carberry 8f55f5c28b chore: ensure go.mod has proper references to forked deps (#6893) 
There were a few that have been merged upstream!
 2023-03-30 11:19:11 -05:00
Kyle Carberry a6b7e8c43a chore: use an older version of fastclock to resolve leak (#6892) 2023-03-30 10:58:56 -05:00
Kyle Carberry 04e404e448 chore: dial the remote socket continually until connect (#6891) 
It's possible that the command starts but the socket isn't ready
even when the file exists.
 2023-03-30 15:36:23 +00:00
Kyle Carberry 5686fc9983 chore: skip chdir template push test on windows (#6890) 
See https://github.com/coder/coder/actions/runs/4565958214/jobs/8057842941
 2023-03-30 10:21:13 -05:00
Kyle Carberry 401b9276ae chore: clone styles to prevent race (#6888) 
See https://github.com/coder/coder/actions/runs/4565541977/jobs/8056830691?pr=6885
 2023-03-30 10:18:24 -05:00
Kyle Carberry 5c1dc1b7fe fix: iterate through all workspace updates on logs overflow (#6885) 
This was causing some flakes!
 2023-03-30 10:05:45 -05:00
Kyle Carberry e470162305 chore: move away from set-output in GitHub Actions (#6884) 
This is deprecated! See:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
 2023-03-30 09:58:56 -05:00
Kyle Carberry 1f600fc526 chore: use defer instead of t.Cleanup for chdir (#6887) 
This _might_ resolve the races in `TestTemplatePush`.
 2023-03-30 09:48:03 -05:00
Kyle Carberry 6378294071 chore: upgrade from deprecated protobuf import (#6883) 
This was displaying a warning when running `go get ./...`.
 2023-03-30 14:17:44 +00:00
Kyle Carberry a2d3635207 fix: update tailscale to resolve h2 vs http/1.1 (#6827) 
DERP will always fallback to WebSockets if h2 is chosen now!
 2023-03-27 21:05:10 +00:00
Kyle Carberry 5e01e6e448 fix: check if logs are completed before publishing (#6824) 2023-03-27 15:50:53 -05:00
Kyle Carberry ad0c0df104 chore: update tailscale to fix http2 upgrade (#6811) 
See https://github.com/coder/tailscale/pull/15
 2023-03-27 14:22:11 -05:00
Kyle Carberry ffb4cd5962 chore: fix race when expecting parameters (#6814) 
See https://github.com/coder/coder/actions/runs/4532378002/jobs/7983840014
 2023-03-27 14:18:33 -05:00
Kyle Carberry d7d210de36 Revert "chore: update tailscale to fix http2 upgrade (#6761)" (#6779) 
This reverts commit 622fc6d9c2.
 2023-03-24 12:40:05 -05:00
Kyle Carberry 622fc6d9c2 chore: update tailscale to fix http2 upgrade (#6761) 
See https://github.com/coder/tailscale/pull/15
 2023-03-24 11:20:21 -05:00
Kyle Carberry 2383f64d89 fix: add dbauthz for streaming startup logs (#6758) 
This was causing logs to end early!
 2023-03-23 15:02:29 -05:00
Kyle CarberryandAsher cb7375450b feat: add startup script logs to the ui (#6558) 
* Add startup script logs to the database

* Add coderd endpoints for startup script logs

* Push startup script logs from agent

* Pull startup script logs on frontend

* Rename queries

* Add constraint

* Start creating log sending loop

* Add log sending to the agent

* Add tests for streaming logs

* Shorten notify channel name

* Add FE

* Improve bulk log performance

* Finish UI display

* Fix startup log visibility

* Add warning for overflow

* Fix agent queue logs overflow

* Display staartup logs in a virtual DOM for performance

* Fix agent queue with loads of logs

* Fix authorize test

* Remove faulty test

* Fix startup and shutdown reporting error

* Fix gen

* Fix comments

* Periodically purge old database entries

* Add test fixture for migration

* Add Storybook

* Check if there are logs when displaying features

* Fix startup component overflow gap

* Fix startup log wrapping

---------

Co-authored-by: Asher <ash@coder.com>
 2023-03-23 14:09:13 -05:00
Kyle Carberry ed9a3b9251 fix: use a background context when piping derp connections (#6750) 
This was causing boatloads of connects to reestablish every time...

See https://github.com/coder/coder/issues/6746
 2023-03-23 09:54:07 -05:00
Kyle Carberry dab4a0e6ef fix: add ResourceUserData to provisionerd to allow git auth (#6743) 
This was breaking passing a git auth token through!
 2023-03-22 17:23:49 -05:00
Kyle Carberry df31636e72 feat: pass access_token to coder_git_auth resource (#6713) 
This allows template authors to leverage git auth to perform
custom actions, like clone repositories.
 2023-03-22 19:37:08 +00:00
Kyle Carberry ad9c9b468f fix: block updating mutable parameters (#6717) 2023-03-22 11:05:04 -05:00
Kyle Carberry 38d278ac46 fix: use the default value for a rich parameter if unset (#6715) 
This fixes an error thrown on the workspace settings page when
a new parameter is added and the workspace hasn't been built yet.
 2023-03-22 00:02:55 +00:00
Kyle Carberry abe1e89f80 chore: increase parallelism of TestWorkspaceQuota (#6710) 
This does a lot of build operations, so having multiple provisioner
daemons is great.

We were actually approaching the ceiling here for test duration!
 2023-03-21 22:44:01 +00:00
Kyle Carberry 7e854adbb3 fix: poll audit logs to ensure write is last (#6708) 2023-03-21 19:19:09 +00:00
Kyle Carberry 71eecb3515 chore: embed build info in the html to reduce requests (#6605) 
This will reduce a request on every page load of Coder!
 2023-03-21 19:04:54 +00:00
Kyle Carberry e1c755be81 chore: remove fast metric cache interval for apps tests (#6702) 
This wasn't helping CI run fast, that's for sure!
 2023-03-21 18:13:34 +00:00
Kyle Carberry aaa3b31a0b chore: add echo helper to create an agent with token (#6576) 
This should reduce some LOC and duplication in tests!
 2023-03-21 18:03:38 +00:00
Kyle Carberry d05b48267a fix: update tailscale to resolve websocket stun fallback (#6696) 
See https://github.com/coder/tailscale/pull/14
 2023-03-21 12:37:34 -05:00
Kyle Carberry 247470b1d6 fix: increase timeout of CreateTemplatePage initial render (#6694) 
This might fix some test flakes we've been seeing!
 2023-03-21 13:24:07 -03:00
Kyle Carberry 1b35ac80f2 fix: ensure agent DisconnectedAt is greater than or equal LastConnectedAt (#6692) 
See https://github.com/coder/coder/actions/runs/4471502401/jobs/7856475920
 2023-03-21 11:08:39 -05:00
Kyle Carberry c3fb1b325f feat: add owner_oidc_access_token to coder_workspace data source (#6042) 
See the discussion in Discord here:
https://discord.com/channels/747933592273027093/1071182088490987542/1071182088490987542

Related provider PR: coder/terraform-provider-coder#91
 2023-03-17 15:25:08 -05:00
Kyle CarberryandColin Adler ffca3a5fb3 fix: remove noop templates plan command (#6617) 
Co-authored-by: Colin Adler <colin1adler@gmail.com>
 2023-03-16 21:28:22 +00:00
Kyle Carberry b693b9f599 chore: fix workspace audit log flake (#6494) 
This happened because sometimes a build would be queued
and completed intermittently in CI.

See https://github.com/coder/coder/actions/runs/4358121985/jobs/7618290591
 2023-03-16 12:47:54 -05:00
Kyle Carberry f91b3acf93 fix: group routine workspace agent stats by id (#6601) 
Before this was creating separate rows for distinct stat entries, which
resulted in significantly more data being sent to telemetry.
 2023-03-14 10:52:03 -05:00
Kyle Carberry 17bc5794d4 fix: direct embedded derp traffic directly to the server (#6595) 
Prior to this change, DERP traffic would route from `coderd` to the
`CODER_ACCESS_URL` to reach the internal DERP server, which may have
resulted in slower connections due to proxying, or the failure of
web traffic entirely.

If your Coder deployment has a proxy in front of it, your traffic through
web terminals, apps, and port-forwarding is about to get a lot faster!
 2023-03-14 14:46:47 +00:00
Kyle Carberry 35df1b10d0 feat: add workspace agent stat reporting to telemetry (#6577) 
This aggregates stats periodically and sends them by agent ID to
our telemetry server. It should help us identify which editors are
primarily in use.
 2023-03-13 14:16:54 -05:00
Kyle Carberry 7fa6483d84 fix: allow the BINARY_DIR to be configured in the agent script (#6567) 2023-03-11 19:39:40 +00:00